Skip to content

Fix for #2893 - do not attempt WorkloadIdentityCredential for MSI FIC (for Id.Web v2) - #2894

Merged
Jean-Marc Prieur (jmprieur) merged 3 commits into
rel/v2from
bogavril/2893
Jun 27, 2024
Merged

Jean-Marc Prieur (jmprieur) merged 3 commits into
rel/v2from
bogavril/2893

Conversation

@bgavrilMS

Copy link
Copy Markdown
Member

See #2813

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand.

@bgavrilMS Bogdan Gavril (bgavrilMS) changed the title Fix for #2893 - do not attempt WorkloadIdentityCredential for MSI FIC Fix for #2893 - do not attempt WorkloadIdentityCredential for MSI FIC (for Id.Web v2) Jun 17, 2024
@bgavrilMS

Copy link
Copy Markdown
Member Author

Jean-Marc Prieur (@jmprieur) jennyf19 - gentle ping on this.

@jennyf19

Copy link
Copy Markdown
Collaborator

why not cherry-pick the other commit?

@bgavrilMS

Copy link
Copy Markdown
Member Author

why not cherry-pick the other commit?

It is subtly different, because in 3.x we introduced a breaking change to the base classes. Have a look at e3a059f#diff-d515a839836ec1adc2d63d93fb6c38698476023fa4b444ca4f62424f8a3fa19aR56

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We should run a release build ...

@jmprieur
Jean-Marc Prieur (jmprieur) deleted the bogavril/2893 branch June 27, 2024 21:35
This was referenced Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants