Skip to content

document SBOM external references - #459

Merged
hboutemy merged 2 commits into
masterfrom
external-reference-doc
Jan 19, 2024
Merged

hboutemy merged 2 commits into
masterfrom
external-reference-doc

Conversation

@hboutemy

Copy link
Copy Markdown
Contributor

default external references filled from POM + additional ones configured in plugin
while at it, also documented other fields converted from POM

@hboutemy hboutemy self-assigned this Jan 19, 2024
@hboutemy
hboutemy force-pushed the external-reference-doc branch from aae4a13 to e0e7a0f Compare January 19, 2024 07:29
Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
@hboutemy
hboutemy force-pushed the external-reference-doc branch from e0e7a0f to df83d58 Compare January 19, 2024 07:32

@ppkarwasz ppkarwasz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

/**
* This test ensures that any <i>compile</i> dependencies hidden by excluded types are included in the BOM if they are visible dependencies
* @throws Exception
* @throws Exception if something unexpected happens

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we really need to document tests?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or there is a warning at build time: just added minimum text to avoid warning

Signed-off-by: Volkan Yazıcı <volkan@yazi.ci>
@hboutemy
hboutemy merged commit a964c6e into master Jan 19, 2024
@hboutemy
hboutemy deleted the external-reference-doc branch January 19, 2024 14:26
@github-actions

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants