Repository navigation
SA1306: Clarify protected field naming - #4355
Merged
Merged
Conversation
Document the casing conventions for protected, private protected, and protected internal fields to clarify the behavior reported in #3552. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The documentation updates consistently describe existing behavior, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Clarifies SA1306 documentation for protected field naming, addressing #3552 without changing analyzer behavior.
Changes:
- Explains casing for mutable and readonly
protectedandprivate protectedfields. - Clarifies uppercase naming for
protected internalfields. - Updates Czech, Russian, and Chinese translations.
| File | Description |
|---|---|
| documentation/zh-cn/SA1306.md | Adds matching Chinese guidance. |
| documentation/SA1306.md | Clarifies protected field casing conventions. |
| documentation/ru-ru/SA1306.md | Adds matching Russian guidance. |
| documentation/cs-cz/SA1306.md | Adds matching Czech guidance. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4355 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 1336 1336
Lines 149792 149792
Branches 5098 5098
=======================================
Hits 146239 146239
Misses 2265 2265
Partials 1288 1288 🚀 New features to boost your workflow:
|
This was referenced Nov 11, 2026
Bump StyleCop.Analyzers from 1.2.0-beta.556 to 1.3.180
microsoftgraph/aspnetcore-webhooks-sample#436
Open
Open
This was referenced Nov 13, 2026
Open
Open
Open
Merged
Open
Bump StyleCop.Analyzers from 1.2.0-beta.556 to 1.3.180
microsoftgraph/msgraph-sample-aspnet-core#256
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3552
Clarifies the casing conventions for mutable and readonly protected/private protected fields, and for protected internal fields, in the SA1306 documentation. The existing casing behavior is unchanged. Updated the Czech, Russian, and Chinese translations to match.
Documentation-only change; no tests run.