Skip to content

GA4GHTT-276: 4.4 changes - optional meta, format CN, CICN, PSL, PSO, PSQ - #254

Merged
tcezard merged 4 commits into
EBIvariation:dev/vcf4.4from
vasudeva8:44-4-1
Sep 4, 2024
Merged

tcezard merged 4 commits into
EBIvariation:dev/vcf4.4from
vasudeva8:44-4-1

Conversation

@vasudeva8

Copy link
Copy Markdown
Collaborator

Remaining changes for vcf4.4
Type P, format tags PSL, PSO, PSQ, CN type update and CICN addition.
PSO validation is to match the count to PSL fields. No check on cached records made as it might not be efficient.
Description made optional for ALT and FILTER meta data.

Format CICN validated with presence of format CN and warning generated on CICN value when it doesn't span across 0.
Check on SVLEN with CN moved from optional/warning to mandatory/error (SV to have same SVLEN when format CN is present).

@vasudeva8
vasudeva8 requested a review from tcezard August 14, 2024 12:58
Comment thread inc/util/string_utils.hpp
* @param ret return by reference the container filled with the string split.
*/
template<typename C>
void string_split_ex(std::string const & s, char const * delims, C & ret, bool withdelim)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need to keep both implementation ?
If you don't want to replace all calls to the extended version I would at least use string_split_ex in string_split

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was retained to avoid any impact.
Updated to use _ex with no delimiter and tests succeeded without any failure.
Updated PR with the change.

Comment thread inc/vcf/file_structure.hpp Resolved
vasudeva8 and others added 2 commits August 27, 2024 18:26
Co-authored-by: Timothee Cezard <tcezard@ebi.ac.uk>
@tcezard
tcezard merged commit 1ccb5a1 into EBIvariation:dev/vcf4.4 Sep 4, 2024
@vasudeva8
vasudeva8 deleted the 44-4-1 branch May 30, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants