Skip to content

Add ErrorReportConfiguration - #1067

Merged
cowtowncoder merged 3 commits into
FasterXML:2.16from
JooHyukKim:1043-1-add-new-ErrorReportConfiguration
Jul 29, 2023
Merged

cowtowncoder merged 3 commits into
FasterXML:2.16from
JooHyukKim:1043-1-add-new-ErrorReportConfiguration

Conversation

@JooHyukKim

Copy link
Copy Markdown
Member

part of #1066

*
* @since 2.16
*/
public class ErrorReportConfigurationTest

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unit-test.

All the tests in the original PR #1043 had JsonFactory, IOContext, etc in scope, so they will be added later along the way.

private static ErrorReportConfiguration DEFAULT =
new ErrorReportConfiguration(DEFAULT_MAX_ERROR_TOKEN_LENGTH, DEFAULT_MAX_RAW_CONTENT_LENGTH);

public static void overrideDefaultErrorReportConfiguration(final ErrorReportConfiguration errorReportConfiguration) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you copy Javadoc from matching method in StreamWriteConstaints, warning against use of this method?
In general it should not be used and specifically libraries should not change global defaults, ever.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually I can do this.

@cowtowncoder
cowtowncoder merged commit 5a562cf into FasterXML:2.16 Jul 29, 2023
@cowtowncoder cowtowncoder changed the title Add new ErrorReportConfiguration Add ErrorReportConfiguration Jul 29, 2023
cowtowncoder added a commit that referenced this pull request Jul 29, 2023
@cowtowncoder

Copy link
Copy Markdown
Member

Thank you @JooHyukKim !

@JooHyukKim
JooHyukKim deleted the 1043-1-add-new-ErrorReportConfiguration branch July 29, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants