Skip to content

Implement new JsonFactory.builder().errorReportConfiguration() - #1072

Merged
cowtowncoder merged 6 commits into
FasterXML:2.16from
JooHyukKim:1043-4-JsonFactory-builder
Aug 3, 2023
Merged

cowtowncoder merged 6 commits into
FasterXML:2.16from
JooHyukKim:1043-4-JsonFactory-builder

Conversation

@JooHyukKim

Copy link
Copy Markdown
Member

part of #1066

@JooHyukKim
JooHyukKim marked this pull request as ready for review August 2, 2023 01:54
/**
* Unit tests for class {@link ErrorReportConfiguration#getMaxErrorTokenLength()}.
*/
public class ErrorReportConfigurationMaxErrorTokenLengthTest extends BaseTest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about combine various tests related to ErrorReportConfiguration, instead of separate test classes? Or at least these two.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for sure πŸ‘πŸ»

@JooHyukKim
JooHyukKim requested a review from cowtowncoder August 2, 2023 22:44
@cowtowncoder
cowtowncoder merged commit 5239017 into FasterXML:2.16 Aug 3, 2023
@cowtowncoder

Copy link
Copy Markdown
Member

Thanks! Merged up to master as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants