Skip to content

feature(rss): add option to set a stylesheet - #432

Merged
Guts merged 2 commits into
mainfrom
feature/add-xsl-option
Apr 9, 2026
Merged

Guts merged 2 commits into
mainfrom
feature/add-xsl-option

Conversation

@Guts

@Guts Guts commented Apr 9, 2026

Copy link
Copy Markdown
Owner

It comes with a special value to use the XSL shipped with the plugin

@github-actions github-actions Bot added documentation Improvements or additions to documentation enhancement New feature or request quality Tests, project resiliency, etc. labels Apr 9, 2026
@codecov

codecov Bot commented Apr 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.54%. Comparing base (46d2f0f) to head (ac4fb39).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
mkdocs_rss_plugin/plugin.py 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   83.74%   83.54%   -0.20%     
==========================================
  Files          11       11              
  Lines         769      784      +15     
  Branches      129      132       +3     
==========================================
+ Hits          644      655      +11     
- Misses         82       84       +2     
- Partials       43       45       +2     
Flag Coverage Δ
unittests 83.54% <73.33%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mkdocs_rss_plugin/config.py 100.00% <100.00%> (ø)
mkdocs_rss_plugin/models.py 100.00% <100.00%> (ø)
mkdocs_rss_plugin/plugin.py 89.50% <69.23%> (-1.77%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Guts
Guts force-pushed the feature/add-xsl-option branch from 9278c68 to ac4fb39 Compare April 9, 2026 20:29
@sonarqubecloud

sonarqubecloud Bot commented Apr 9, 2026

Copy link
Copy Markdown

@Guts
Guts merged commit 18bc7a9 into main Apr 9, 2026
13 checks passed
@Guts
Guts deleted the feature/add-xsl-option branch April 9, 2026 20:31
@Guts Guts self-assigned this May 13, 2026
Guts added a commit to qgis/qgis-plugin-ci that referenced this pull request May 15, 2026
…man readable (#400)

<!-- Thanks for your contribution to this project! Please make sure you
read the following guidelines before opening a pull request. -->

## Description

With this PR, running:

```sh
qgis-plugin-ci package -c -u https://oslandia.gitlab.io/qgis/oslandia/ latest
```

creates a `plugins.xml` file with this line `<?xml-stylesheet
type="text/xsl" href="plugins.xsl"?>` which references the
`plugins.xsl`.

Once web served (typically `python -m http.server 8000`):

<img width="1066" height="584" alt="image"
src="https://github.com/user-attachments/assets/99dbcd18-36b8-4711-b8f8-ba7e63212e9a"
/>

A new `--no-repository-stylesheet` option disable this behavior.

Also in this PR:

- add missing docstrings

Closes #375

AI: I mainly copied/pasted what I've done on the [Mkdocs RSS
plugin](Guts/mkdocs-rss-plugin#432) but I was
tired to clean up for this use case so I tell claude.ai to do it.

Funded by Oslandia

<!-- osl:grant-oss-2026 -->

## Author's checklist

- [x] I have read the [contributing
guidelines](https://github.com/opengisch/qgis-plugin-ci?tab=contributing-ov-file#readme)
and my pull request follows them.
- [x] my commits tend to comply with [Conventional
Commits](https://www.conventionalcommits.org/); so they are descriptive
and explain the rationale for changes. Messages and description are
self-explanatory to make the git log a readable story of the project.
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added necessary documentation (if appropriate).
- [x] commits which fix bugs include `Fixes #11111` at the bottom of the
commit message.

> [!TIP]
> If you forgot to do this, don't be shy and write the same statement
into this text field with the pull request description.

### AI tool usage

- [x] AI tool(s) (Copilot, Claude, or something similar) supported my
development of this PR. See our [policy about AI tool
use](https://github.com/qgis/QGIS-Enhancement-Proposals/blob/master/qep-408-ai-tool-policy.md).
Use of AI tools *must* be indicated. Failure to be honest might result
in banning.

<!--
**BEFORE HITTING SUBMIT** -- Please SPIN UP THE DOCKERIZED PROJECT AND
TEST your changes thoroughly. This is YOUR responsibility! Do NOT rely
on the project maintainers to do this for you!

IMPORTANT NOTES FOR FIRST TIME CONTRIBUTORS
===========================================

Congratulations, you are about to make a pull request to QGIS or one of
its related project! To make this as easy and pleasurable for everyone,
please take the time to read these lines before opening the pull
request.

Include a few sentences describing the overall goals for this pull
request (PR). If applicable also add screenshots or - even better -
screencasts.
Include both: *what* you changed and *why* you changed it.

If this is a pull request that adds new functionality which needs
documentation, give an especially detailed explanation.
In this case, start with a short abstract and then write some text that
can be copied 1:1 to the documentation in the best case.

-->

## Reviewer's checklist

- [ ] I remember to check the "Author's checklist" above and ask the
author to update the PR description if any of the items are not checked.
- [ ] I remember that welcoming new contributors is more important than
nitpicking on code style. I will be kind and respectful in my review
comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request quality Tests, project resiliency, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant