Repository navigation
Document how to use in Browserify… - #29
Conversation
… library to one with a CommoJS API more similar to Fetch.
There was a problem hiding this comment.
It doesn't look like native-promise-only was packaged for npm, not bower.
There was a problem hiding this comment.
crumbs, i'll put it back
There was a problem hiding this comment.
Ah, so native-promise-only doesn't require an explicit export when used in CJS mode.
I'd be cool recommending either. I guess thats the nice thing about it being optional is that you can use whatever promise polyfill you like.
There was a problem hiding this comment.
Yeah, es6-shim is the same and appears to have bower support?
[I am completely subscribed to this point of view: https://github.com/matthew-andrews/denodeify]
|
Is this OK to merge or would you like to make any changes? |
|
It looks good to me @matthew-andrews. I was waiting for @dgraham to review and merge. |
Document how to use in Browserify…
|
Thanks for writing this up! |
… as per #21. This is just a quick first pass, I'm almost certainly using too many words here.
native-promise-onlyas I believe its API is more similar to the CommonJS API fetch has*. Would you like me to change that back?* The equivalent for
es6-promiseis:It would be nice if we can do #9 because it would simplify some of this explanation (around fuzzy versions/version ranges) greatly.