Repository navigation
Remove form encoded object body. - #30
Merged
Merged
Conversation
This was based on a misreading of the URLSearchParams portion of section 5.2 of https://fetch.spec.whatwg.org/#body-mixin. Use FormData as the request body to POST form fields instead.
Contributor
Author
|
If the site has jQuery available, but not fetch(form.getAttribute('action'), {
method: form.getAttribute('method'),
body: $.param($(form).serializeArray()),
headers: {
'Content-Type': 'application/x-www-form-urlencoded; charset=UTF-8'
}
) |
The body must be consumed through the `text`, `json`, `formData`, or `blob` functions.
|
I'm not sure I understand what you're saying. |
Contributor
Author
|
fetch('/query', {
method: 'post',
body: {
name: 'Hubot',
name: 'Duplicate Hubot',
login: 'hubot'
}
})I misread the spec, thinking that |
dgraham
added a commit
that referenced
this pull request
Nov 3, 2014
Remove form encoded object body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was based on a misreading of the URLSearchParams portion of section 5.2 of https://fetch.spec.whatwg.org/#body-mixin.
Form encoding an Object doesn't work for keys that occur several times in one request body, like
issues[]=12&issues[]=42. Use FormData as the request body to POST form fields instead./cc @annevk on spec compliance.