Skip to content

Switch to mocha-phantomjs-core and system PhantomJS - #314

Merged
mislav merged 1 commit into
masterfrom
update-mocha-phantomjs
Apr 14, 2016
Merged

mislav merged 1 commit into
masterfrom
update-mocha-phantomjs

Conversation

@mislav

@mislav mislav commented Apr 14, 2016

Copy link
Copy Markdown
Contributor

This switches to the more lightweight mocha-phantomjs-core project that allows us to use system PhantomJS, which should be the later 2.x series rather than 1.9.

/cc @dgraham

@mislav
mislav force-pushed the update-mocha-phantomjs branch from 11f8643 to d1ab588 Compare April 14, 2016 07:04
@mislav

mislav commented Apr 14, 2016

Copy link
Copy Markdown
Contributor Author

Hmm seems like Travis CI still has PhantomJS on 1.9.8. But at least locally you're free to test on whatever is the system version. Passes for me on 2.1.1

@dgraham

dgraham commented Apr 14, 2016

Copy link
Copy Markdown
Contributor

:shipit:

@mislav
mislav merged commit b259545 into master Apr 14, 2016
@mislav
mislav deleted the update-mocha-phantomjs branch April 14, 2016 19:17
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants