Repository navigation
Reject promise with TypeError for network failures. - #36
Merged
Merged
Conversation
Contributor
|
β¨ |
dgraham
added a commit
that referenced
this pull request
Nov 21, 2014
Reject promise with TypeError for network failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 5.6 Fetch method of the specification says:
This branch brings the implementation in line with step one of the response handling. Previously, we rejected the Promise without a reason object when the network request failed to produce a response. Now we reject with a
TypeErrorfor any registeredcatchhandlers to process.@annevk Is this a correct understanding of this section of the spec?