Repository navigation
Accept array in Headers constructor - #485
Merged
Merged
Conversation
Contributor
|
The native Thanks for the detailed bug report and fix. |
mislav
approved these changes
Feb 22, 2017
| } else if (Array.isArray(headers)) { | ||
| headers.forEach(function(header) { | ||
| this.append(header[0], header[1]); | ||
| }, this); |
Contributor
Author
|
Thanks for pulling this in @dgraham. Any chance for an updated release with the fix? |
Contributor
|
The 2.0.3 release is now available on npm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the spec, it looks like the
Headersconstructor should accept an array of arrays.I've adapted the example for the tests:
This came up for me as an issue using
stream-httpin Edge with the Financial Times polyfill. I've opened jhiesey/stream-http#71 and polyfillpolyfill/polyfill-service#1091 in case this can be addressed elsewhere, but it looks to me like this might be the right fix.