Skip to content

Assign to self - #52

Merged
josh merged 5 commits into
masterfrom
self
Dec 29, 2014
Merged

josh merged 5 commits into
masterfrom
self

Conversation

@josh

@josh josh commented Dec 29, 2014

Copy link
Copy Markdown
Contributor

isomorphic-fetch will need to be changed to stub global.self instead of global.window.

https://github.com/matthew-andrews/isomorphic-fetch/blob/master/server.js

Changes #48.
Obsoletes #49, #50.

cc @dgraham @matthew-andrews @knowledgecode

@matthew-andrews

Copy link
Copy Markdown
Contributor

If that works for you that works for me :-).

Ready when you are…

matthew-andrews/isomorphic-fetch#3

Comment thread .jshintrc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make more sense to switch the worker option on rather than defining self as a global.

(Similarly but potentially less importantly you could choose to switch on esnext instead of defining Promise as a global β€”Β but that defines a larger amount of stuff that you might not want defined)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, I didn't realize there was a worker option.

I'll give exnext a try too. Last time I think I was on an older jshint that didn't define Promise yet.

@knowledgecode

Copy link
Copy Markdown
Contributor

πŸ‘

@dgraham

dgraham commented Dec 29, 2014

Copy link
Copy Markdown
Contributor

:shipit:

josh added a commit that referenced this pull request Dec 29, 2014
@josh
josh merged commit 8beeeee into master Dec 29, 2014
@josh
josh deleted the self branch December 29, 2014 18:31
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants