Skip to content

Update Karma and detect available browsers when testing - #652

Merged
mislav merged 9 commits into
masterfrom
karma-update
Sep 4, 2018
Merged

mislav merged 9 commits into
masterfrom
karma-update

Conversation

@mislav

@mislav mislav commented Sep 3, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@mislav
mislav requested a review from a team September 3, 2018 18:13
Comment thread test/karma.config.js Outdated
preferHeadless: true,
usePhantomJS: false,
postDetection: availableBrowsers =>
availableBrowsers.map(browser => (browser.startsWith('Chrom') ? `${browser}NoSandbox` : browser))

@keithamus keithamus Sep 3, 2018 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is Chrom intentional here? never mind I see it also catches Chromium

@mislav

mislav commented Sep 3, 2018

Copy link
Copy Markdown
Contributor Author

This change causes a bizarre CI failure:

HeadlessChrome 0.0.0 (Ubuntu 0.0.0) native Request credentials defaults to same-origin FAILED
	AssertionError: expected 'omit' to equal 'same-origin'

Which would suggest that the version of Chrome used was 62, not 68. This branch uses the same karma-chrome-launcher version as master, so I can't guess right now why would the result be different.

@mislav
mislav merged commit fde38d5 into master Sep 4, 2018
@mislav
mislav deleted the karma-update branch September 4, 2018 00:04
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants