Skip to content

Add metadata for repository, bugs and license - #67

Merged
josh merged 2 commits into
JakeChampion:masterfrom
danez:patch-1
Jan 22, 2015
Merged

josh merged 2 commits into
JakeChampion:masterfrom
danez:patch-1

Conversation

@danez

@danez danez commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

This would be nice as this information is displayed in the npm repository.

@domenic

domenic commented Jan 14, 2015

Copy link
Copy Markdown

bugs is redundant with repository and repository can just be "repository": "github/fetch"

@danez

danez commented Jan 14, 2015

Copy link
Copy Markdown
Contributor Author

Oh I haven't checked that in detail, will do it later.

@danez

danez commented Jan 22, 2015

Copy link
Copy Markdown
Contributor Author

@domenic I couldn't find any reference on what you said, all examples state, you should us a full url to your repository. And bugs is a different url that is used by git bugs

And the markup was copied from an official package, so it should be quite correct.

@domenic

domenic commented Jan 22, 2015

Copy link
Copy Markdown

It's correct, but it's way longer than it needs to be, and a maintenance burden.

Here's another official package or three you can copy markup from:

@domenic

domenic commented Jan 22, 2015

Copy link
Copy Markdown

@danez

danez commented Jan 22, 2015

Copy link
Copy Markdown
Contributor Author

Seems this shorter way of defining the guthub repository is not covered in the official docs about package.json.
Now its changed.

josh added a commit that referenced this pull request Jan 22, 2015
Add metadata for repository, bugs and license
@josh
josh merged commit 9a1ef9d into JakeChampion:master Jan 22, 2015
@josh

josh commented Jan 22, 2015

Copy link
Copy Markdown
Contributor

cools

@danez
danez deleted the patch-1 branch January 22, 2015 20:03
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants