Skip to content

Add a convenience ok getter on Response - #82

Merged
dgraham merged 2 commits into
JakeChampion:masterfrom
matthew-andrews:ok
Feb 9, 2015
Merged

dgraham merged 2 commits into
JakeChampion:masterfrom
matthew-andrews:ok

Conversation

@matthew-andrews

Copy link
Copy Markdown
Contributor

[ https://github.com/whatwg/fetch/commit/e62f57b6c923f16e877ab56913a2a65388a7535a ]

Also wondering if also need to polyfill ok on the next version of Chrome where fetch might now be a partial implementation (sorry, google. my bad…)


Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1126483

Comment thread fetch.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra semicolon here.

@dgraham

dgraham commented Jan 27, 2015

Copy link
Copy Markdown
Contributor

We could wait to see if this appears in Chrome and Firefox nightlies before merging.

@matthew-andrews matthew-andrews changed the title Add a convenience ok getter on Response (fixes #18) Add a convenience ok getter on Response Jan 27, 2015
@matthew-andrews

Copy link
Copy Markdown
Contributor Author

Yep sure, that's fine by me. Would you mind me keeping the PR open in the meantime?

@dgraham

dgraham commented Jan 28, 2015

Copy link
Copy Markdown
Contributor

Yep, let's keep this open!

@josh

josh commented Jan 28, 2015

Copy link
Copy Markdown
Contributor

❀️

dgraham added a commit that referenced this pull request Feb 9, 2015
Add a convenience `ok` getter on `Response`
@dgraham
dgraham merged commit 2f2ed4c into JakeChampion:master Feb 9, 2015
@dgraham

dgraham commented Feb 9, 2015

Copy link
Copy Markdown
Contributor

The ok attribute is now in Firefox and Chrome nightly builds.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants