Repository navigation
Conversation
LNPANDY
added a commit
that referenced
this pull request
Oct 26, 2026
nn::oe::EnableAlbumImageTakenNotification had no HLE entry while its Disable counterpart did. A game that turns the notification on early reads through am's applet proxy, which the host never made, so the call hit a null. m1guelpf's one-line fix, verified rather than taken on faith: - the mangled name is exactly right (c++filt: nn::oe::EnableAlbumImageTakenNotification(), and the 33-character class prefix matches Itanium ABI β the Disable entry's 34 is the same rule) - hle_oe.c is not a carrier this fork patches, so the entry survives the daily sync untouched - the host builds (0 errors) and the unit suite reaches its existing end state (the audio device stall test fails identically without this patch β a host-audio environment issue, not this) Applied by hand and the PR closes with credit.
Owner
|
Applied by hand in Three things I checked rather than assuming, since this is a hand-written mangled name:
One request for the future: if you have a game or a log that showed the null read, mention the title ID β it makes the entry's comment self-documenting for the next person, the way the neighbouring lines name The Great Ace Attorney Chronicles. |
LNPANDY
added a commit
that referenced
this pull request
Oct 27, 2026
v0lumehi's PR #27 turned the Mac front end into a launcher library (40 files), and m1guelpf's #24/#26 fixed two HLE entries that games read through as nulls. Neither appeared anywhere in the README, and the first thing a new visitor sees should include who built what beyond the maintainer. Both names link their PRs so the work is one click away; the section ends by pointing at Contributing, since a visible contributor list is also an invitation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing
EnableAlbumImageTakenNotificationfunction