Skip to content

add missing function - #24

Closed
m1guelpf wants to merge 1 commit into
LNPANDY:mainfrom
m1guelpf:screenshot-taken
Closed

m1guelpf wants to merge 1 commit into
LNPANDY:mainfrom
m1guelpf:screenshot-taken

Conversation

@m1guelpf

Copy link
Copy Markdown

Adds missing EnableAlbumImageTakenNotification function

LNPANDY added a commit that referenced this pull request Oct 26, 2026
nn::oe::EnableAlbumImageTakenNotification had no HLE entry while its Disable counterpart did.
A game that turns the notification on early reads through am's applet proxy, which the host never
made, so the call hit a null. m1guelpf's one-line fix, verified rather than taken on faith:

- the mangled name is exactly right (c++filt: nn::oe::EnableAlbumImageTakenNotification(), and the
  33-character class prefix matches Itanium ABI β€” the Disable entry's 34 is the same rule)
- hle_oe.c is not a carrier this fork patches, so the entry survives the daily sync untouched
- the host builds (0 errors) and the unit suite reaches its existing end state (the audio device
  stall test fails identically without this patch β€” a host-audio environment issue, not this)

Applied by hand and the PR closes with credit.
@LNPANDY LNPANDY closed this Oct 26, 2026
@LNPANDY

LNPANDY commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Applied by hand in 0a550b1, with credit β€” thank you. It is exactly the kind of gap that is invisible until a game trips on it: DisableAlbumImageTakenNotification had an entry and Enable did not, so any title that turns the notification on before anything else reads through am's applet proxy (which the host never made) and hits a null.

Three things I checked rather than assuming, since this is a hand-written mangled name:

  • The symbol is exact. c++filt gives nn::oe::EnableAlbumImageTakenNotification(), and the 33 prefix is the class name's length in Itanium ABI β€” the neighbouring Disable entry's 34 follows the same rule, so the pair is consistent.
  • It survives the daily sync. hle_oe.c is not a file this fork patches, so the entry is not at risk of being reverted on the next upstream pull (the patcher set is small and explicit; this file is not in it).
  • It builds and the suite's state is unchanged. The host compiles with no errors, and the host unit suite ends on the same pre-existing audio-device stall failure it does without the patch (a host-audio environment issue on this machine β€” verified by stashing the change and re-running).

One request for the future: if you have a game or a log that showed the null read, mention the title ID β€” it makes the entry's comment self-documenting for the next person, the way the neighbouring lines name The Great Ace Attorney Chronicles.

LNPANDY added a commit that referenced this pull request Oct 27, 2026
v0lumehi's PR #27 turned the Mac front end into a launcher library (40 files), and m1guelpf's
#24/#26 fixed two HLE entries that games read through as nulls. Neither appeared anywhere in the
README, and the first thing a new visitor sees should include who built what beyond the
maintainer. Both names link their PRs so the work is one click away; the section ends by pointing
at Contributing, since a visible contributor list is also an invitation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants