You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 27, 2022. It is now read-only.
Repository navigation
LL-8941 Conditionally auto disconnect the node-hid-singleton - #797
Here's the second attempt at getting a automatic release of the node-hid-singleton. After the talk we had the other day @gre I think that by exposing this method setAllowAutoDisconnect at the transport level and allowing it to override the auto-disconnect (basically re-scheduling it again) will allow us to call transport.setAllowAutoDisconnect(false) at the begining of the withDevice implementation on hw/deviceAccess from live-common and unsetting the flag on the onClose for the transport, we essentially bypass the problem we have of long running tasks inside a withDevice instance.
Merging #797 (32b4a72) into master (daf99ca) will increase coverage by 0.49%.
The diff coverage is n/a.
β Current head 32b4a72 differs from pull request most recent head e0189b9. Consider uploading reports for the commit e0189b9 to get more accurate results
I would like a tagged version of the node-hid-singleton package so that I can make a PR on live-common that disables auto-disconnect inside withDevice and then test it on LLD. Think we can release this to test @gre ? I'd rather not do it considering the mess I caused last time π
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the second attempt at getting a automatic release of the node-hid-singleton. After the talk we had the other day @gre I think that by exposing this method
setAllowAutoDisconnectat the transport level and allowing it to override the auto-disconnect (basically re-scheduling it again) will allow us to calltransport.setAllowAutoDisconnect(false)at the begining of thewithDeviceimplementation onhw/deviceAccessfrom live-common and unsetting the flag on theonClosefor the transport, we essentially bypass the problem we have of long running tasks inside awithDeviceinstance.What do you think?