Skip to content

Fix EmptyTask references in benchmark and tutorials - #2070

Merged
rlratzel merged 2 commits into
NVIDIA-NeMo:mainfrom
rlratzel:fix-emptytask-benchmark-docs
Jun 11, 2026
Merged

rlratzel merged 2 commits into
NVIDIA-NeMo:mainfrom
rlratzel:fix-emptytask-benchmark-docs

Conversation

@rlratzel

Copy link
Copy Markdown
Contributor

Summary

Validation

  • ast-parse checked changed Python files
  • git diff --check
  • pre-commit hooks passed during signed-off commit

Signed-off-by: rlratzel <rratzel@nvidia.com>
@rlratzel
rlratzel requested a review from a team as a code owner June 11, 2026 19:22
@rlratzel
rlratzel requested review from ayushdg and removed request for a team June 11, 2026 19:22
@greptile-apps

greptile-apps Bot commented Jun 11, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates all user-facing examples, tutorials, benchmarks, and documentation to use the public EmptyTask symbol instead of the private _EmptyTask alias, following the refactor introduced in #2062.

  • Six files are updated with purely mechanical renames: _EmptyTask → EmptyTask in imports, type annotations, docstrings, and inline comments.
  • EmptyTask is confirmed publicly exported from nemo_curator/tasks/__init__.py, so all updated call sites are correct.

Confidence Score: 5/5

Safe to merge — all changes are mechanical renames of a private symbol to its public equivalent, confirmed exported from the tasks package.

Every change is a straightforward substitution of _EmptyTask with EmptyTask, which is verified as a public export in nemo_curator/tasks/__init__.py. No logic, runtime behaviour, or interfaces are altered.

No files require special attention.

Important Files Changed

Filename Overview
benchmarking/scripts/arxiv_e2e_pipeline_benchmark.py Import and type-annotation updated from _EmptyTask to EmptyTask; no logic changes.
nemo_curator/stages/text/download/README.md Data-flow comment updated from _EmptyTask to EmptyTask; documentation-only change.
tutorials/audio/callhome_diar/run.py Import, class generic, and process method signature updated to use public EmptyTask.
tutorials/interleaved/nemotron_parse_pdf/main.py Docstring stage-flow comment updated from _EmptyTask to EmptyTask; no code change.
tutorials/quickstart.py Import, class generic, and process method signature updated to public EmptyTask.
tutorials/slurm/pipeline.py Docstring, import, class generic, and process method signature updated to public EmptyTask.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["EmptyTask (public)"] -->|"was _EmptyTask (private)"| B["Pipeline seed / root task"]
    B --> C["FileGroupTask / AudioTask / SampleTask / DocumentBatch"]
    C --> D["Downstream processing stages"]

    style A fill:#d4edda,stroke:#28a745
    style B fill:#fff3cd,stroke:#ffc107
Loading

Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." | Re-trigger Greptile

@rlratzel
rlratzel enabled auto-merge (squash) June 11, 2026 19:39
…mark-docs

Signed-off-by: rlratzel <rratzel@nvidia.com>

This branch was previously deployed

3 inactive (2 outdated) deployments
public — b05a0f76 Deployed Jun 11, 2026 by copy-pr-bot[bot] via release / finalize / notify #272
nemo-ci — 674ecb3e Deployed Jun 11, 2026 by copy-pr-bot[bot] via L0_Unit_Test_GPU-serve #4647
test — 674ecb3e Deployed Jun 11, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #4647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants