Skip to content

fix: AUT-2228 route partial reruns to the current attempt - #2381

Merged
chtruong814 merged 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:fix/partial-rerun-runner-labels
Sep 8, 2026
Merged

chtruong814 merged 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:fix/partial-rerun-runner-labels

Conversation

@svcnemo-autobot

Copy link
Copy Markdown
Contributor

Background

Partial workflow reruns inherit outputs from successful prerequisite jobs, which can retain an obsolete attempt-qualified runner label.

What changed

Pinned the routing helper to v1.9.2, passed runner_label_base through preflight, and appended github.run_attempt at each rerun-eligible Curator scheduling boundary.

Details

Legacy labels remain unchanged because the attempt suffix is added only for ephe-v2- labels.

flowchart LR
  R[Routing base] --> P[Preflight]
  P --> J[Runner consumer]
  A[Current attempt] --> J
Loading

Tested

  • Parsed the changed workflow as YAML
  • Verified all three runner consumers use the guarded expression
  • Verified the preflight pin stayed unchanged
  • Ran applicable YAML, whitespace, size, case, and private-key checks

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested a review from a team as a code owner September 8, 2026 17:05
@copy-pr-bot

copy-pr-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge, with no concrete correctness, security, or repository-rule violations identified.

Summary

  • Pins the routing reusable workflow to v1.9.2 and passes its base runner label through preflight.
  • Appends the current run-attempt suffix at each affected Curator runner consumer.
  • Preserves legacy runner labels through an ephe-v2- prefix guard.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Routing["_ephemeral_runner_routing.yml v1.9.2"] -->|"runner_label_base"| Preflight["Preflight"]
  Preflight -->|"runner_prefix"| Guard{"Starts with ephe-v2-?"}
  Attempt["github.run_attempt"] --> Guard
  Guard -->|"Yes: append -aN"| Consumers["Container build and GPU jobs"]
  Guard -->|"No: preserve label"| Consumers
Loading

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the gpuci Run GPU CI/CD on PR label Sep 8, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test 3c0a3f9

@chtruong814
chtruong814 enabled auto-merge (squash) September 8, 2026 17:39
@chtruong814
chtruong814 merged commit 0fd74b7 into NVIDIA-NeMo:main Sep 8, 2026
64 checks passed
tromanski-nv pushed a commit to tromanski-nv/Curator that referenced this pull request Sep 14, 2026
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

This branch was previously deployed

3 inactive deployments
nemo-ci — 3c0a3f9b Deployed Sep 8, 2026 by copy-pr-bot[bot] via L0_Unit_Test_GPU-image #5447
public — 3c0a3f9b Deployed Sep 8, 2026 by copy-pr-bot[bot] via release / finalize / notify #998
test — 3c0a3f9b Deployed Sep 8, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #5447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gpuci Run GPU CI/CD on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants