Skip to content

ci: Run L0+L1 tests on dependency bump PRs - #2887

Merged
ko3n1g merged 1 commit into
mainfrom
ko3n1g/ci/run-all-tests-on-dependabot
Mar 18, 2026
Merged

ko3n1g merged 1 commit into
mainfrom
ko3n1g/ci/run-all-tests-on-dependabot

Conversation

@ko3n1g

@ko3n1g ko3n1g commented Mar 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds labels: needs-more-tests to the peter-evans/create-pull-request step in _update_dependencies.yml

Why

The cicd-main.yml L1 tests only run on main push, scheduled runs, workflow_dispatch, or PRs labeled needs-more-tests. Dependency bump PRs created by _update_dependencies.yml had none of these, so L1 tests were silently skipped — only L0 ran.

Adding this label ensures both L0 and L1 tests run on every bump PR before it is auto-merged.

Test plan

  • Trigger _update_dependencies.yml and verify the created bump PR has needs-more-tests label
  • Confirm L1 jobs appear in the CI run for that PR

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the automated dependency update workflow to automatically label pull requests with "needs-more-tests" for improved testing visibility and review coordination.

@ko3n1g
ko3n1g requested a review from a team as a code owner March 18, 2026 18:54
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
ko3n1g force-pushed the ko3n1g/ci/run-all-tests-on-dependabot branch from 06e22c1 to ce0b96a Compare March 18, 2026 18:56
@coderabbitai

coderabbitai Bot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 56ef6383-019f-48ea-99bc-823fb0d07bb5

📥 Commits

Reviewing files that changed from the base of the PR and between 31d0ade and 06e22c1.

📒 Files selected for processing (1)
  • .github/workflows/_update_dependencies.yml

📝 Walkthrough

Walkthrough

A single line was added to the GitHub Actions workflow file that configures dependency updates. The change adds a labels input parameter to apply the "needs-more-tests" label to pull requests automatically created during the dependency update process. This is a configuration-only change with no impact on workflow logic.

Changes

Cohort / File(s) Summary
GitHub Actions Configuration
.github/workflows/_update_dependencies.yml
Added labels input to the Create Bump PR step to automatically assign the "needs-more-tests" label to generated pull requests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title mentions running L0+L1 tests on dependency bump PRs, but the actual change only adds a label to trigger tests—it doesn't implement test execution. Clarify whether the title should reflect the implementation detail (adding 'needs-more-tests' label) or verify it accurately describes the functional outcome (ensuring L0+L1 tests run).
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only a minor CI/workflow configuration change—adding a single label to a GitHub Actions step with no impact on code logic or performance.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ko3n1g/ci/run-all-tests-on-dependabot
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ko3n1g
ko3n1g merged commit 1961a38 into main Mar 18, 2026
18 of 19 checks passed
@ko3n1g
ko3n1g deleted the ko3n1g/ci/run-all-tests-on-dependabot branch March 18, 2026 19:11
copy-pr-bot Bot pushed a commit that referenced this pull request Mar 19, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>

This branch had an error being deployed

1 failed and 1 inactive deployments
nemo-ci — ce0b96a6 Deployed Mar 18, 2026 by copy-pr-bot[bot] via Launch_Unit_Tests_Diffusion #8890
test — ce0b96a6 Deployed Mar 18, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #8890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants