Repository navigation
ci: Skip coverage job for mcore triggered tests - #2897
Merged
Merged
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
📝 WalkthroughWalkthroughA conditional gate was added to the Coverage job in the CI/CD workflow to prevent execution when the workflow is dispatched using MCore. The job now requires Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
Author
|
Fast merging this to fix the MCore trigger tests as well as the sso user check |
copy-pr-bot Bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
ci: Skip coverage job for mcore triggered tests
The MCore triggered tests are now failing because the coverage e2e jobs are failing since only unit tests are ran during a PR. This just skips the coverage jobs if mcore refs are passed because they are not necessary for those workflows.
Example:
https://github.com/NVIDIA-NeMo/Megatron-Bridge/actions/runs/23274131634
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Summary by CodeRabbit