Skip to content

ci: Skip coverage job for mcore triggered tests - #2897

Merged
chtruong814 merged 4 commits into
mainfrom
chtruong/fix-coverage-mcore
Mar 19, 2026
Merged

chtruong814 merged 4 commits into
mainfrom
chtruong/fix-coverage-mcore

Conversation

@chtruong814

@chtruong814 chtruong814 commented Mar 19, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do ?

ci: Skip coverage job for mcore triggered tests

The MCore triggered tests are now failing because the coverage e2e jobs are failing since only unit tests are ran during a PR. This just skips the coverage jobs if mcore refs are passed because they are not necessary for those workflows.

Example:
https://github.com/NVIDIA-NeMo/Megatron-Bridge/actions/runs/23274131634

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Refined CI/CD coverage check conditions to improve workflow efficiency.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@coderabbitai

coderabbitai Bot commented Mar 19, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

A conditional gate was added to the Coverage job in the CI/CD workflow to prevent execution when the workflow is dispatched using MCore. The job now requires github.event.inputs.mcore_ref to be empty.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/cicd-main.yml
Added condition github.event.inputs.mcore_ref == '' to the Coverage job's if gate to skip execution when MCore-dispatched workflows run.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding logic to skip the coverage job when MCore triggers the workflow, which directly matches the changeset modification to the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor CI/CD changes—a single-line addition to GitHub Actions workflow condition to skip Coverage job when MCore-triggered tests execute.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chtruong/fix-coverage-mcore
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814

Copy link
Copy Markdown
Contributor Author

Fast merging this to fix the MCore trigger tests as well as the sso user check

@chtruong814
chtruong814 merged commit c0f2fd0 into main Mar 19, 2026
32 checks passed
@chtruong814
chtruong814 deleted the chtruong/fix-coverage-mcore branch March 19, 2026 04:10
copy-pr-bot Bot pushed a commit that referenced this pull request Mar 19, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>

This branch was previously deployed

2 inactive deployments
nemo-ci — 63ad52a7 Deployed Mar 19, 2026 by copy-pr-bot[bot] via L0_Launch_utils #9004
test — 63ad52a7 Deployed Mar 19, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #9004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant