Skip to content

[docs] chore: Add area:diffusion label and test resource constraints - #3036

Merged
yaoyu-33 merged 1 commit into
mainfrom
yuya/contributing-docs-diffusion-test-resources
Mar 30, 2026
Merged

yaoyu-33 merged 1 commit into
mainfrom
yuya/contributing-docs-diffusion-test-resources

Conversation

@yaoyu-33

@yaoyu-33 yaoyu-33 commented Mar 30, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates CONTRIBUTING.md with two documentation improvements:

  1. area:diffusion label — adds the label to the inline area label list and the area labels reference table
  2. Test resource guidance — documents that unit tests are strongly preferred over functional tests due to limited CI resources, and that functional tests must use at most 2 GPUs

Changelog

  • Add area:diffusion to area label list and table in CONTRIBUTING.md
  • Add callout recommending unit tests over functional tests
  • Add 2-GPU limit constraint for functional tests

GitHub Actions CI

See the CI section in the Contributing doc.

Summary by CodeRabbit

  • Documentation
    • Added new diffusion area label for organizing commits and pull requests related to diffusion model implementations.
    • Updated testing guidelines to prioritize unit tests and limit functional tests to a maximum of 2 GPUs.

@copy-pr-bot

copy-pr-bot Bot commented Mar 30, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaoyu-33

Copy link
Copy Markdown
Contributor Author

/ok to test 77578d4

- Add area:diffusion to label list and area labels table in CONTRIBUTING.md
- Add guidance that unit tests are strongly preferred over functional tests
- Add 2-GPU limit for functional tests due to CI resource constraints

Signed-off-by: Yu Yao <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33
yaoyu-33 force-pushed the yuya/contributing-docs-diffusion-test-resources branch from 77578d4 to d54782e Compare March 30, 2026 23:42
@yaoyu-33

Copy link
Copy Markdown
Contributor Author

/ok to test d54782e

@coderabbitai

coderabbitai Bot commented Mar 30, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 38ee4774-bdbf-43eb-b070-f9e1b5c25689

📥 Commits

Reviewing files that changed from the base of the PR and between 3cf48a1 and d54782e.

📒 Files selected for processing (1)
  • CONTRIBUTING.md

📝 Walkthrough

Walkthrough

Updated CONTRIBUTING.md to add a new diffusion area label for diffusion model implementations and training. Also revised test-writing guidance to prioritize unit tests over functional tests and impose a maximum 2 GPU constraint on functional tests.

Changes

Cohort / File(s) Summary
Documentation & Labeling Guidelines
CONTRIBUTING.md
Added diffusion area label to commit/PR areas and Area Labels taxonomy. Updated test-writing guidance to prefer unit tests and limit functional tests to maximum 2 GPUs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yuya/contributing-docs-diffusion-test-resources

Comment @coderabbitai help to get the list of available commands and usage tips.

@yaoyu-33
yaoyu-33 merged commit 23ac10e into main Mar 30, 2026
31 checks passed
@yaoyu-33
yaoyu-33 deleted the yuya/contributing-docs-diffusion-test-resources branch March 30, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant