Repository navigation
[model] fix: pass Step35 layer names through MTP - #4368
Merged
Merged
Conversation
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Light ReviewLGTM — clean, minimal fix. The No issues found. Suggested test casesNo perf tests impacted. |
Contributor
Author
|
/ok to test 8383660 |
cuichenx
approved these changes
Jun 15, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nameconstructor kwarg inStep35DecoderLayernametoTransformerLayerTesting
python3AST check confirmedStep35DecoderLayer.__init__now includesnameuv tool run ruff check src/megatron/bridge/models/stepfun/step35_provider.py tests/unit_tests/models/stepfun/test_step35_provider.pyuv tool run ruff format --check src/megatron/bridge/models/stepfun/step35_provider.py tests/unit_tests/models/stepfun/test_step35_provider.pypython3 -m py_compile src/megatron/bridge/models/stepfun/step35_provider.py tests/unit_tests/models/stepfun/test_step35_provider.pygit diff --checkuv run --active --no-sync pre-commit run --files src/megatron/bridge/models/stepfun/step35_provider.py tests/unit_tests/models/stepfun/test_step35_provider.pyFocused pytest and full pre-commit were attempted with
uv run, but local environment resolution is blocked becausenvidia-resiliency-ext==0.6.0has no compatible wheel for this workstation platform (manylinux_2_31_x86_64; available wheels targetmanylinux_2_39).