Skip to content

[model] fix: pass Step35 layer names through MTP - #4368

Merged
yaoyu-33 merged 1 commit into
mainfrom
felix/step35-name-investigation
Jun 16, 2026
Merged

yaoyu-33 merged 1 commit into
mainfrom
felix/step35-name-investigation

Conversation

@yaoyu-33

Copy link
Copy Markdown
Contributor

Summary

  • Accept and forward the MCore name constructor kwarg in Step35DecoderLayer
  • Add focused unit coverage for the MTP-layer path forwarding name to TransformerLayer
  • Audited custom Bridge TransformerLayer/decoder-layer subclasses for the same constructor-contract issue; no additional clear MTP decoder-layer cases found

Testing

  • python3 AST check confirmed Step35DecoderLayer.__init__ now includes name
  • uv tool run ruff check src/megatron/bridge/models/stepfun/step35_provider.py tests/unit_tests/models/stepfun/test_step35_provider.py
  • uv tool run ruff format --check src/megatron/bridge/models/stepfun/step35_provider.py tests/unit_tests/models/stepfun/test_step35_provider.py
  • python3 -m py_compile src/megatron/bridge/models/stepfun/step35_provider.py tests/unit_tests/models/stepfun/test_step35_provider.py
  • git diff --check
  • uv run --active --no-sync pre-commit run --files src/megatron/bridge/models/stepfun/step35_provider.py tests/unit_tests/models/stepfun/test_step35_provider.py

Focused pytest and full pre-commit were attempted with uv run, but local environment resolution is blocked because nvidia-resiliency-ext==0.6.0 has no compatible wheel for this workstation platform (manylinux_2_31_x86_64; available wheels target manylinux_2_39).

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@claude

claude Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Light Review

LGTM — clean, minimal fix. The name kwarg is accepted and forwarded to super().__init__() correctly, and the test coverage directly verifies the forwarding path via the recorder pattern.

No issues found.

Suggested test cases

No perf tests impacted.

@yaoyu-33 yaoyu-33 added the r0.5.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. label Jun 15, 2026
@yaoyu-33

Copy link
Copy Markdown
Contributor Author

/ok to test 8383660

@yaoyu-33 yaoyu-33 added area:model Model implementations and HF bridge logic bug Something isn't working ready-to-merge PR is approved, current, and only waiting for CI to pass before merge labels Jun 15, 2026
@yaoyu-33
yaoyu-33 merged commit 2e4322c into main Jun 16, 2026
103 of 105 checks passed
@yaoyu-33
yaoyu-33 deleted the felix/step35-name-investigation branch June 16, 2026 01:52

This branch was previously deployed

2 inactive deployments
public — 83836606 Deployed Jun 15, 2026 by copy-pr-bot[bot] via release / finalize / notify #1530
test — 83836606 Deployed Jun 15, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #16373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:model Model implementations and HF bridge logic bug Something isn't working r0.5.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. ready-to-merge PR is approved, current, and only waiting for CI to pass before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants