Repository navigation
feat(conversion): add HF embedding row repair script - #5005
Conversation
|
/ok to test 109a44b |
|
Light review - LGTM Self-contained offline utility with clear contracts, good safety guards (max_rows abort, damaged-output-source rejection, post-repair norm verification, output-path nesting check), and reasonable README docs. No correctness or logic issues found, no typos, and no perf/recipe configs are touched. Minor, non-blocking observations: Test-coverage gaps. The three unit tests cover the sharded-repair, dry-run, and damaged-output-source paths, but several guarded branches are untested:
README nit: the new repair_hf_embedding_rows.py section is inserted just above the numbered '1. hf_megatron_roundtrip.py' entry, so an unnumbered tool now precedes the numbered list. Harmless, but slightly odd ordering. Suggested test cases
|
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
109a44b to
14a6307
Compare
|
/ok to test 14a6307 |
Summary
Nano 4B Check
Checked nvidia/NVIDIA-Nemotron-3-Nano-4B-BF16 model.safetensors via HTTP range reads of only:
With min_norm=1.0e-4:
Repaired row IDs:
1192, 1193, 1245, 1246, 1247, 1248, 1249, 1250, 1251, 1252, 1253, 1254, 1255, 25304, 42819, 51067, 55014, 56286, 67044, 77579, 81422, 81691, 81695, 81772, 81815, 81819, 82005, 82267, 82312, 82500, 82690, 82725, 82737, 82977, 83362, 83855, 84006, 84105, 84115, 84121, 84521, 84794, 85015, 86060, 86366, 86409, 87020, 87411, 88346, 89406, 89412, 90101, 90294, 90320, 90703, 91368, 91515, 91608, 91762, 92529, 96374, 96385, 98573, 101707, 104097, 105465, 106921, 108262, 109896, 112147, 112277, 112327, 112497, 114442, 114755, 116654, 117123, 117744, 118025
Testing
Note: uv run pre-commit run --all-files was attempted after initializing 3rdparty/Megatron-LM, but cannot resolve on this macOS host because nvidia-resiliency-ext==0.6.0 only publishes manylinux wheels.