Repository navigation
fix(github): send get_issue label filters as one comma-separated value - #2359
Merged
rapids-bot[bot] merged 1 commit intoOct 16, 2026
Merged
rapids-bot[bot] merged 1 commit into
rapids-bot[bot] merged 1 commit into
Conversation
The GitHub list-issues endpoint reads `labels` as a single comma-separated value. get_issue passed the label list straight to httpx, which repeats the query parameter (labels=a&labels=b), and GitHub then filters by the last label only. Join the labels before sending the request. Signed-off-by: abhishekacharya200 <abhishekacharya200@users.noreply.github.com>
Member
|
/ok to test e17c534 |
willkill07
approved these changes
Oct 16, 2026
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
githubfunction group'sget_issuepassedlabelsto httpx as a list. httpx sends a list as a repeated query parameter (labels=bug&labels=Needs%20Triage), but the GitHub list-issues endpoint readslabelsas one comma-separated value and keeps only the last one. A filter for several labels therefore returned issues that have only the last label.get_issuenow joins the labels into one value (labels=bug,Needs%20Triage) before sending the request.I checked this against the live API on this repository:
labels=bug&labels=Needs%20Triagereturns the same issues aslabels=Needs%20Triage(includingfeature requestanddocissues), whilelabels=bug,Needs%20Triagereturns only issues with both labels.Added
test_get_issue_sends_labels_as_one_comma_separated_valueinpackages/nvidia_nat_core/tests/nat/tools/test_github_tools.py. It builds the function group with anhttpx.MockTransportand checks the query string. It fails ondevelop(['bug', 'Needs Triage']) and passes with the fix.Validation (Python 3.12):
pytest packages/nvidia_nat_core/tests/nat/tools: 50 passed, 7 skipped (49 passed, 7 skipped ondevelop).yapf --diffandruff checkon both changed files: no changes or findings.Closes #2358
Maintainer metadata: please add the
bugandnon-breakinglabels.By Submitting this PR I confirm:
Summary by CodeRabbit
bugandNeeds Triagesends them as one labels filter, while other issue search criteria remain unchanged.