Repository navigation
Test tuple of iterator reference assignment - #1964
Merged
Merged
Conversation
This was referenced Jul 9, 2024
Contributor
🟨 CI finished in 2h 45m: Pass: 98%/249 | Total: 1d 05h | Avg: 7m 04s | Max: 31m 23s | Hits: 99%/244677
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental |
🏃 Runner counts (total jobs: 249)
| # | Runner |
|---|---|
| 178 | linux-amd64-cpu16 |
| 40 | linux-amd64-gpu-v100-latest-1 |
| 16 | linux-arm64-cpu16 |
| 15 | windows-amd64-cpu16 |
bernhardmgruber
force-pushed
the
tupleofrefsbug
branch
from
March 5, 2025 09:17
e9dec7b to
0a07352
Compare
Contributor
Author
|
/ok to test |
Contributor
🟩 CI finished in 1h 49m: Pass: 100%/93 | Total: 18h 12m | Avg: 11m 44s | Max: 1h 39m | Hits: 94%/133878
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 93)
| # | Runner |
|---|---|
| 66 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 4 | linux-arm64-cpu16 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
miscco
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was hunting the following bug, which does not seem to occur anymore. So here is just the test for it.
The problem seemed to be that when the assignment operator is instantiated:
it will ultimately lead to a check whether a
tuple<Ts...>is constructible from atuple<Us...>, which asks wether adevice_reference<T>is constructible from adevice_reference<const T>, which rightfully fails. However, the correct check would whethertuple<Ts...>is assignable from atuple<Us...>.What's so astounding is that this bug only surfaces on a few GCC versions.