Repository navigation
cudastf (examples): Fix compiler errors when enabling examples for CUDA STF - #3516
Merged
Merged
Conversation
Contributor
miscco
approved these changes
Jan 24, 2025
miscco
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Thanks a lot for fixing those
Contributor
|
pre-commit.ci autofix |
Contributor
|
/ok to test |
Contributor
|
I am surprised these warnings did not show in the CI ... thanks @janciesko |
caugonnet
approved these changes
Jan 27, 2025
Contributor
🟩 CI finished in 5h 18m: Pass: 100%/20 | Total: 1h 51m | Avg: 5m 33s | Max: 17m 24s | Hits: 388%/522
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 20)
| # | Runner |
|---|---|
| 12 | linux-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 2 | windows-amd64-cpu16 |
| 2 | linux-amd64-gpu-v100-latest-1 |
miscco
approved these changes
Jan 28, 2025
Contributor
|
Thanks again for fixing those warnings |
davebayer
pushed a commit
to davebayer/cccl
that referenced
this pull request
Jan 29, 2025
…DA STF (NVIDIA#3516) * Make index types consistent in loops * Add implementation of missing operator Co-authored-by: Jan Ciesko <jciesko@gmail.com> Co-authored-by: Cédric Augonnet <158148890+caugonnet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes to address compiler errors.
Description
Errors encountered:
Environment:
Checklist