Skip to content

cudastf (examples): Fix compiler errors when enabling examples for CUDA STF - #3516

Merged
bernhardmgruber merged 4 commits into
NVIDIA:mainfrom
janciesko:fix_size_t_stf1
Jan 28, 2025
Merged

bernhardmgruber merged 4 commits into
NVIDIA:mainfrom
janciesko:fix_size_t_stf1

Conversation

@janciesko

Copy link
Copy Markdown
Contributor

Minor fixes to address compiler errors.

Description

Errors encountered:

cccl/cudax/examples/stf/linear_algebra/cg_csr.cu:244:20: error: implicitly-declared ‘scalar& scalar::operator=(const scalar&)’ is deprecated [-Werror=deprecated-copy]
  244 |     rsold = mv(rsnew);
cccl/cudax/examples/stf/linear_algebra/07-potri.cu:1405:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
 1405 |         for (int n = 0; n < B.nt; n++)

Environment:

nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2023 NVIDIA Corporation
Built on Fri_Nov__3_17:22:02_PDT_2023
Cuda compilation tools, release 12.3, V12.3.103
Build cuda_12.3.r12.3/compiler.33492891_0

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@janciesko
janciesko requested a review from a team as a code owner January 23, 2025 20:56
@janciesko
janciesko requested a review from alliepiper January 23, 2025 20:56
@copy-pr-bot

copy-pr-bot Bot commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@miscco miscco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks a lot for fixing those

@miscco

miscco commented Jan 27, 2025

Copy link
Copy Markdown
Contributor

pre-commit.ci autofix

@caugonnet

Copy link
Copy Markdown
Contributor

/ok to test

@caugonnet

Copy link
Copy Markdown
Contributor

I am surprised these warnings did not show in the CI ... thanks @janciesko

@caugonnet caugonnet added the stf Sequential Task Flow programming model label Jan 27, 2025
@github-actions

Copy link
Copy Markdown
Contributor
🟩 CI finished in 5h 18m: Pass: 100%/20 | Total: 1h 51m | Avg: 5m 33s | Max: 17m 24s | Hits: 388%/522
  • 🟩 cudax: Pass: 100%/20 | Total: 1h 51m | Avg: 5m 33s | Max: 17m 24s | Hits: 388%/522

    🟩 cpu
      🟩 amd64              Pass: 100%/16  | Total:  1h 39m | Avg:  6m 13s | Max: 17m 24s | Hits: 388%/522   
      🟩 arm64              Pass: 100%/4   | Total: 11m 30s | Avg:  2m 52s | Max:  3m 33s
    🟩 ctk
      🟩 12.0               Pass: 100%/1   | Total: 10m 09s | Avg: 10m 09s | Max: 10m 09s | Hits: 388%/261   
      🟩 12.5               Pass: 100%/2   | Total: 10m 46s | Avg:  5m 23s | Max:  5m 26s
      🟩 12.6               Pass: 100%/17  | Total:  1h 30m | Avg:  5m 18s | Max: 17m 24s | Hits: 388%/261   
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/1   | Total: 10m 09s | Avg: 10m 09s | Max: 10m 09s | Hits: 388%/261   
      🟩 nvcc12.5           Pass: 100%/2   | Total: 10m 46s | Avg:  5m 23s | Max:  5m 26s
      🟩 nvcc12.6           Pass: 100%/17  | Total:  1h 30m | Avg:  5m 18s | Max: 17m 24s | Hits: 388%/261   
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/20  | Total:  1h 51m | Avg:  5m 33s | Max: 17m 24s | Hits: 388%/522   
    🟩 cxx
      🟩 Clang14            Pass: 100%/1   | Total:  3m 05s | Avg:  3m 05s | Max:  3m 05s
      🟩 Clang15            Pass: 100%/1   | Total:  3m 31s | Avg:  3m 31s | Max:  3m 31s
      🟩 Clang16            Pass: 100%/1   | Total:  3m 22s | Avg:  3m 22s | Max:  3m 22s
      🟩 Clang17            Pass: 100%/1   | Total:  3m 21s | Avg:  3m 21s | Max:  3m 21s
      🟩 Clang18            Pass: 100%/4   | Total: 25m 59s | Avg:  6m 29s | Max: 16m 27s
      🟩 GCC10              Pass: 100%/1   | Total:  3m 06s | Avg:  3m 06s | Max:  3m 06s
      🟩 GCC11              Pass: 100%/1   | Total:  3m 32s | Avg:  3m 32s | Max:  3m 32s
      🟩 GCC12              Pass: 100%/2   | Total: 20m 42s | Avg: 10m 21s | Max: 17m 24s
      🟩 GCC13              Pass: 100%/4   | Total: 10m 47s | Avg:  2m 41s | Max:  2m 51s
      🟩 MSVC14.36          Pass: 100%/1   | Total: 10m 09s | Avg: 10m 09s | Max: 10m 09s | Hits: 388%/261   
      🟩 MSVC14.39          Pass: 100%/1   | Total: 12m 53s | Avg: 12m 53s | Max: 12m 53s | Hits: 388%/261   
      🟩 NVHPC24.7          Pass: 100%/2   | Total: 10m 46s | Avg:  5m 23s | Max:  5m 26s
    🟩 cxx_family
      🟩 Clang              Pass: 100%/8   | Total: 39m 18s | Avg:  4m 54s | Max: 16m 27s
      🟩 GCC                Pass: 100%/8   | Total: 38m 07s | Avg:  4m 45s | Max: 17m 24s
      🟩 MSVC               Pass: 100%/2   | Total: 23m 02s | Avg: 11m 31s | Max: 12m 53s | Hits: 388%/522   
      🟩 NVHPC              Pass: 100%/2   | Total: 10m 46s | Avg:  5m 23s | Max:  5m 26s
    🟩 gpu
      🟩 v100               Pass: 100%/20  | Total:  1h 51m | Avg:  5m 33s | Max: 17m 24s | Hits: 388%/522   
    🟩 jobs
      🟩 Build              Pass: 100%/18  | Total:  1h 17m | Avg:  4m 17s | Max: 12m 53s | Hits: 388%/522   
      🟩 Test               Pass: 100%/2   | Total: 33m 51s | Avg: 16m 55s | Max: 17m 24s
    🟩 sm
      🟩 90                 Pass: 100%/1   | Total:  2m 44s | Avg:  2m 44s | Max:  2m 44s
      🟩 90a                Pass: 100%/1   | Total:  2m 51s | Avg:  2m 51s | Max:  2m 51s
    🟩 std
      🟩 17                 Pass: 100%/4   | Total: 13m 29s | Avg:  3m 22s | Max:  5m 26s
      🟩 20                 Pass: 100%/16  | Total:  1h 37m | Avg:  6m 06s | Max: 17m 24s | Hits: 388%/522   
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 20)

# Runner
12 linux-amd64-cpu16
4 linux-arm64-cpu16
2 windows-amd64-cpu16
2 linux-amd64-gpu-v100-latest-1

@miscco

miscco commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Thanks again for fixing those warnings

@bernhardmgruber
bernhardmgruber merged commit 81b1af6 into NVIDIA:main Jan 28, 2025
davebayer pushed a commit to davebayer/cccl that referenced this pull request Jan 29, 2025
…DA STF (NVIDIA#3516)

* Make index types consistent in loops
* Add implementation of missing operator

Co-authored-by: Jan Ciesko <jciesko@gmail.com>
Co-authored-by: Cédric Augonnet <158148890+caugonnet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stf Sequential Task Flow programming model

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants