Skip to content

Fix deprecation warnings for Qt classes. - #911

Merged
acolwell merged 1 commit into
NatronGitHub:RB-2.5from
acolwell:fix_deprecated_warnings
Sep 5, 2023
Merged

acolwell merged 1 commit into
NatronGitHub:RB-2.5from
acolwell:fix_deprecated_warnings

Conversation

@acolwell

@acolwell acolwell commented Sep 4, 2023

Copy link
Copy Markdown
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Fixes deprecation warnings for a few Qt classes. This simply uses default constructors for parameter defaults instead of deprecated constants.

Have you tested your changes (if applicable)? If so, how?

Yes. Code builds locally without the deprecation warnings now.

@acolwell
acolwell requested a review from devernay September 5, 2023 00:56

@devernay devernay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolwell
acolwell merged commit 2739096 into NatronGitHub:RB-2.5 Sep 5, 2023
@acolwell
acolwell deleted the fix_deprecated_warnings branch September 5, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants