Skip to content

fix(board): tier-gate umulige mål, ensret stjerne-tælling, fix pulje-krydset reaktion - #3171

Merged
NicolaiDolmer merged 6 commits into
mainfrom
fix/3095-board-goal-bugs
Jul 31, 2026
Merged

NicolaiDolmer merged 6 commits into
mainfrom
fix/3095-board-goal-bugs

Conversation

@NicolaiDolmer

Copy link
Copy Markdown
Owner

Hvad

Tre beslægtede bestyrelses-bugs fixet i samme domæne (board/bestyrelse, backend):

  1. Mål-generering injicerede/tilbød et strukturelt umuligt mål (monument/klassiker-podie) i tier 3/4.
  2. 5-års-planens stjerne-rytter-mål talte efter et andet kriterium end board-kortets egen stjerne-optælling.
  3. Bestyrelsens race-mærkede satisfaction-event blev skrevet for alle hold uanset division/pulje.

Refs #3095 #3141 #3144

Hvorfor

Alle tre kom ind via Discord-feedback (ugesweep 2026-07-30) og deler samme rodårsags-familie: bestyrelsesmotoren manglede et tier-/pulje-bevidst filter på et sted hvor et andet sted i koden allerede havde det rigtige filter (samme mønster som tidligere #1238/#2276).

Detaljer pr. issue

#3095 — italiensk_klassiker-DNA's monument-mål umuligt i tier 3/4

Rod-årsag: boardClubDna.buildDnaTraditionGoal() og boardConsequences.selectBonusExtraGoal() injicerede/tilbød et monument_podium-mål uden at tjekke om holdets tier (tierRaceSelection.TIER_CLASS_WHITELIST) overhovedet indeholder de kvalificerende race-klasser (#2276-kaskaden: tier 3/4 kører ALDRIG Monuments eller klassikere).
Fix: Ny delt helper boardConstants.tierSupportsRaceScope(tier, raceScope) — begge steder gater nu mod den, og dropper/erstatter målet når det er umuligt.
Test: boardClubDna.test.js + boardConsequences.test.js — dækker tier 1 (opnåeligt), tier 2 (opnåeligt, OtherWorldTourB/C overlapper), tier 3/4 (umuligt, droppes), samt at ikke-race-klasse-bundne tradition-mål (fx min_national_riders) aldrig gates.
Data-reparation: database/proposals/2026-07-31-3095-italiensk-klassiker-monument-goal-repair.sql — idempotent, fjerner det umulige mål fra current_goals for de 5 bekræftede tier-3-hold (Ardennaise Pro Cycling Team, Bad At Names, Hopplà Team, Kemphanen Cycling Team, Nickstar Rockets). Verificeret read-only mod prod (exact board_id'er + bug-signatur i SQL-kommentarerne). IKKE appliet — ligger i database/proposals/ (uden for auto-migrate.yml's glob) og afventer ejer-godkendelse, samme mønster som #2881.

#3141 — 5-års-planen tæller ikke stjerne-ryttere som bestyrelsen selv anerkender

Rod-årsag: signature_rider-målets evaluator (boardGoals.js, to steder: evaluateGoal + evaluateGoalProgress) brugte rå popularity >= 75, mens board-kortets "bestyrelsen anerkender N stjerne-ryttere" (boardIdentity.js star_profile) bruger et blandet score (popularity*0.70 + uciScore*0.30 >= 68, STAR_RIDER_SCORE_THRESHOLD). En rytter med moderat omdømme men høje UCI-point kunne derfor tælle på board-kortet uden at tælle mod planen (og omvendt).
Fix: calculateRiderStarScore + STAR_RIDER_SCORE_THRESHOLD eksporteret fra boardIdentity.js, begge evaluerings-steder i boardGoals.js bruger nu samme SSOT.
Test: boardGoalTypes.test.js — ny rider-fixture demonstrerer begge retninger af den gamle uoverensstemmelse (score-kvalificeret rytter der IKKE talte under den gamle regel, og popularity-kvalificeret rytter der IKKE er en board-stjerne under den nye).
Copy: goalHelp.signature_rider (EN+DA, frontend/public/locales/{en,da}/board.json) opdateret så teksten matcher det nye kriterium.

#3144 — bestyrelsen reagerer på løb fra en division holdet ikke er i

Rod-årsag: processBoardWeekendFinalization (kaldt pr. finaliseret løb fra raceRunner.js + pcmResultsImport.js) skrev et race-mærket board_satisfaction_events-row for alle rigtige hold, uanset om løbet var i holdets pulje/division. BoardSatisfactionTimeline.jsx viser race_name + satisfaction-delta pr. event — så en Division 2-manager så bestyrelsen "reagere" (grøn +X%) på et Division 3-løb holdet aldrig kørte.
Fix: race.league_division_id sendes nu med fra begge kaldesteder (raceRunner.js x2, pcmResultsImport.js); ny raceMatchesTeamPool(race, standing)-helper filtrerer event-skrivningen til kun hold i løbets egen pulje. Selve satisfaction-tal-mekanikken (target-tracking mod holdets egen standing) er urørt — kun det viste, race-mærkede event er filtreret.
Test: boardWeekendFinalization.test.js — 3 nye tests (pulje-mismatch → intet event, pulje-match → event skrives, løb uden pulje-id → bagudkompatibel/ufiltreret).

Test plan

  • Backend tests: npm test --prefix backend — 4796/4796 grønne
  • Lint: npm run lint --prefix frontend — 0 fejl (4 pre-eksisterende warnings i urørte filer)
  • Frontend build (ikke kørt separat — ingen JS/JSX-ændringer, kun locale-JSON)
  • Manuel: ikke klikket igennem (backend-logik + i18n-tekst, ingen ny UI)
  • Regression: fuld backend-suite dækker board-domænet bredt (boardGoals, boardClubDna, boardConsequences, boardWeekendFinalization, boardGoalContext, boardIdentity — alle grønne)

Brugerverifikation (KRÆVET)

  • Jeg har åbnet feature i prod eller preview-deploy og bekræftet at brugere ser forventet UI/data
  • Jeg har testet som authenticated user
  • Ikke testet end-to-end: backend-only PR (tier-gate ved mål-generering, evaluerings-kriterium, event-skrivnings-filter) + én i18n-tekststreng (tooltip-forklaring, ingen ny UI-flade). Ingen af de tre fixes er synlige som en NY skærm — de ændrer hvornår/om et eksisterende mål/event vises, hvilket kun kan verificeres over en fuld sæson-cyklus for de specifikke ramte hold.

Hvad jeg verificerede konkret: Læste live prod-data (read-only, Supabase MCP) for at bekræfte at de 5 hold i #3095 rent faktisk har bug-signaturen i current_goals og at ingen andre hold er ramt af samme mønster — se SQL-filens kvantificerings-kommentar for de eksakte board_id'er.

Risk / auto-merge

  • auto-merge — IKKE sat: berører bestyrelses-evaluering (satisfaction-tal-flow) + en usignet data-reparation, kræver ejer-review
  • Dependency/security-impact vurderet: ingen package.json/workflow/auth/upload-ændringer

Filer rørt

  • backend/lib/boardClubDna.js, boardConsequences.js, boardConstants.js, boardGoals.js, boardIdentity.js, boardWeekendFinalization.js, pcmResultsImport.js, raceRunner.js + tilhørende .test.js-filer
  • database/proposals/2026-07-31-3095-italiensk-klassiker-monument-goal-repair.sql (ny, IKKE appliet)
  • frontend/public/locales/{en,da}/board.json (kun tekst)

Skærmbillede / video

Ingen — ingen UI-ændring.


Close-out (efter merge til main)

…krydset reaktion

Tre beslægtede bestyrelses-bugs fundet via Discord-feedback (ugesweep 30/7):

- #3095: buildDnaTraditionGoal (italiensk_klassiker) og selectBonusExtraGoal
  injicerede/tilbød monument_podium-mål uden at tjekke om holdets tier
  overhovedet kan producere en klassiker/Monuments-løb (#2276-kaskaden).
  Gates nu begge mod tierRaceSelection.TIER_CLASS_WHITELIST via ny delt
  boardConstants.tierSupportsRaceScope(). Data-reparations-SQL for de 5
  bekræftede ramte tier-3-hold (Ardennaise Pro Cycling Team, Bad At Names,
  Hopplà Team, Kemphanen Cycling Team, Nickstar Rockets) ligger i
  database/proposals/2026-07-31-3095-italiensk-klassiker-monument-goal-repair.sql
  — afventer ejer-godkendelse, IKKE auto-appliet (samme mønster som #2881).
- #3141: signature_rider-målet (5-års-planen) talte ryttere via rå
  popularity>=75, mens board-kortets "bestyrelsen anerkender N
  stjerne-ryttere" bruger et blandet star-score (popularity*0.70 +
  uciScore*0.30 >= 68). Ensrettet til samme SSOT (calculateRiderStarScore +
  STAR_RIDER_SCORE_THRESHOLD, nu eksporteret fra boardIdentity.js).
- #3144: processBoardWeekendFinalization skrev et race-mærket
  board_satisfaction_events-row for ALLE rigtige hold hver gang ÉT løb
  finaliserede, uanset division/pulje — så en Division 2-manager så
  bestyrelsen "reagere" på Division 3-løb holdet aldrig kørte. Filtreret til
  kun at skrive eventet når løbets pulje matcher holdets (raceMatchesTeamPool).

Tests: nye/opdaterede tests dækker alle tre fixes + regression for de gamle
(nu forkerte) forventninger. Fuld backend-suite: 4796/4796 grønne. Frontend:
kun i18n-tekst opdateret (goalHelp.signature_rider EN+DA) — npm run lint 0 fejl.

Refs #3095 #3141 #3144

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cycling-zone Ready Ready Preview Jul 31, 2026 11:44am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 31, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@NicolaiDolmer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b027e1ef-87d2-4148-8ab9-68489714dea8

📥 Commits

Reviewing files that changed from the base of the PR and between 129393d and 6969d2e.

📒 Files selected for processing (15)
  • backend/lib/boardClubDna.js
  • backend/lib/boardClubDna.test.js
  • backend/lib/boardConsequences.js
  • backend/lib/boardConsequences.test.js
  • backend/lib/boardConstants.js
  • backend/lib/boardGoalTypes.test.js
  • backend/lib/boardGoals.js
  • backend/lib/boardIdentity.js
  • backend/lib/boardWeekendFinalization.js
  • backend/lib/boardWeekendFinalization.test.js
  • backend/lib/pcmResultsImport.js
  • backend/lib/raceRunner.js
  • database/proposals/2026-07-31-3095-italiensk-klassiker-monument-goal-repair.sql
  • frontend/public/locales/da/board.json
  • frontend/public/locales/en/board.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 31, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project ghwvkxzhsbbltzfnuhhz because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@NicolaiDolmer
NicolaiDolmer enabled auto-merge (squash) July 31, 2026 11:02
…-dash-gate)

Refs #3141

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

🟡 Lighthouse (advisory — blokerer ikke)

Lab-måling af den byggede frontend (frontend/dist, desktop-preset, median af 3 runs). Scores svinger ±et par point på CI-hardware og uden prod-env — brug dem til at fange STORE fald, ikke som facit. Bundle-size er den hard gate (separat step). Autoritativ perf-måling: ugentlig prod-run + field-CWV i GA4.

Kategori Score
Performance 98
Accessibility 96
Best Practices 96
SEO 100

Fuld rapport-URL i job-artifact lighthouse-results.

@NicolaiDolmer
NicolaiDolmer merged commit fad84f2 into main Jul 31, 2026
38 checks passed
@NicolaiDolmer
NicolaiDolmer deleted the fix/3095-board-goal-bugs branch July 31, 2026 11:51
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deploy verificeret LIVE — fad84f2

  • Vercel deploy: success
  • Railway deploy: success
  • Backend /health = 200
  • Backend /api/auctions (no auth) = 401 (auth gates virker)
  • Frontend root = 200

Du kan trygt lukke telefonen — det er live.

NicolaiDolmer added a commit that referenced this pull request Jul 31, 2026
)

Refs #3095 #3141 #3144

Co-authored-by: Nicolai Dolmer <213100469+NicolaiDolmer@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
NicolaiDolmer added a commit that referenced this pull request Aug 3, 2026
…ation (#3172) (#3222)

* fix(ci): isolate economyEngine.test.js to stop worker-IPC flake

backend/lib/economyEngine.test.js is by far the largest backend test
file (100+ tests, 6500+ lines, ~250KB) and its per-worker result
payload appears large enough to trip a known Node test-runner bug
(nodejs/node#64061, root-caused and fixed upstream in
nodejs/node#64706, merged 2026-07-26 but not yet in our pinned Node
24.x line) when many other test-file workers stream results back to
the parent process concurrently. Isolated runs were always
102/102 (now 103/103) green; the flake only ever showed up in the
full suite (#3169-CI, #3171-CI).

Add backend/scripts/run-tests.js: runs economyEngine.test.js alone
first, then every other backend test file exactly as before (same
flags, same default concurrency) via explicit relative file paths so
the two passes never overlap. Wire both npm test (backend/package.json
- the one permitted package.json edit) and scripts/verify-local.ps1
(which called `node --test` directly, bypassing npm entirely) through
this script so CI and local pre-push runs get the same protection.

No dependency or lockfile changes. Verified with 5 consecutive
`npm test` runs locally (103/103 + 4773/4773 every time, exit 0).

Refs #3172
Co-Authored-By: Claude <noreply@anthropic.com>

* docs(learnings): postmortem for economyEngine.test.js worker-IPC flake

Refs #3172
Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Nicolai Dolmer <213100469+NicolaiDolmer@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — 6969d2e5 Deployed Jul 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant