Repository navigation
fix(board): tier-gate umulige mål, ensret stjerne-tælling, fix pulje-krydset reaktion - #3171
Conversation
…krydset reaktion Tre beslægtede bestyrelses-bugs fundet via Discord-feedback (ugesweep 30/7): - #3095: buildDnaTraditionGoal (italiensk_klassiker) og selectBonusExtraGoal injicerede/tilbød monument_podium-mål uden at tjekke om holdets tier overhovedet kan producere en klassiker/Monuments-løb (#2276-kaskaden). Gates nu begge mod tierRaceSelection.TIER_CLASS_WHITELIST via ny delt boardConstants.tierSupportsRaceScope(). Data-reparations-SQL for de 5 bekræftede ramte tier-3-hold (Ardennaise Pro Cycling Team, Bad At Names, Hopplà Team, Kemphanen Cycling Team, Nickstar Rockets) ligger i database/proposals/2026-07-31-3095-italiensk-klassiker-monument-goal-repair.sql — afventer ejer-godkendelse, IKKE auto-appliet (samme mønster som #2881). - #3141: signature_rider-målet (5-års-planen) talte ryttere via rå popularity>=75, mens board-kortets "bestyrelsen anerkender N stjerne-ryttere" bruger et blandet star-score (popularity*0.70 + uciScore*0.30 >= 68). Ensrettet til samme SSOT (calculateRiderStarScore + STAR_RIDER_SCORE_THRESHOLD, nu eksporteret fra boardIdentity.js). - #3144: processBoardWeekendFinalization skrev et race-mærket board_satisfaction_events-row for ALLE rigtige hold hver gang ÉT løb finaliserede, uanset division/pulje — så en Division 2-manager så bestyrelsen "reagere" på Division 3-løb holdet aldrig kørte. Filtreret til kun at skrive eventet når løbets pulje matcher holdets (raceMatchesTeamPool). Tests: nye/opdaterede tests dækker alle tre fixes + regression for de gamle (nu forkerte) forventninger. Fuld backend-suite: 4796/4796 grønne. Frontend: kun i18n-tekst opdateret (goalHelp.signature_rider EN+DA) — npm run lint 0 fejl. Refs #3095 #3141 #3144 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
…-dash-gate) Refs #3141 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🟡 Lighthouse (advisory — blokerer ikke)Lab-måling af den byggede frontend (
Fuld rapport-URL i job-artifact |
|
✅ Deploy verificeret LIVE —
Du kan trygt lukke telefonen — det er live. |
…ation (#3172) (#3222) * fix(ci): isolate economyEngine.test.js to stop worker-IPC flake backend/lib/economyEngine.test.js is by far the largest backend test file (100+ tests, 6500+ lines, ~250KB) and its per-worker result payload appears large enough to trip a known Node test-runner bug (nodejs/node#64061, root-caused and fixed upstream in nodejs/node#64706, merged 2026-07-26 but not yet in our pinned Node 24.x line) when many other test-file workers stream results back to the parent process concurrently. Isolated runs were always 102/102 (now 103/103) green; the flake only ever showed up in the full suite (#3169-CI, #3171-CI). Add backend/scripts/run-tests.js: runs economyEngine.test.js alone first, then every other backend test file exactly as before (same flags, same default concurrency) via explicit relative file paths so the two passes never overlap. Wire both npm test (backend/package.json - the one permitted package.json edit) and scripts/verify-local.ps1 (which called `node --test` directly, bypassing npm entirely) through this script so CI and local pre-push runs get the same protection. No dependency or lockfile changes. Verified with 5 consecutive `npm test` runs locally (103/103 + 4773/4773 every time, exit 0). Refs #3172 Co-Authored-By: Claude <noreply@anthropic.com> * docs(learnings): postmortem for economyEngine.test.js worker-IPC flake Refs #3172 Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Nicolai Dolmer <213100469+NicolaiDolmer@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Hvad
Tre beslægtede bestyrelses-bugs fixet i samme domæne (board/bestyrelse, backend):
Refs #3095 #3141 #3144
Hvorfor
Alle tre kom ind via Discord-feedback (ugesweep 2026-07-30) og deler samme rodårsags-familie: bestyrelsesmotoren manglede et tier-/pulje-bevidst filter på et sted hvor et andet sted i koden allerede havde det rigtige filter (samme mønster som tidligere #1238/#2276).
Detaljer pr. issue
#3095 — italiensk_klassiker-DNA's monument-mål umuligt i tier 3/4
Rod-årsag:
boardClubDna.buildDnaTraditionGoal()ogboardConsequences.selectBonusExtraGoal()injicerede/tilbød etmonument_podium-mål uden at tjekke om holdets tier (tierRaceSelection.TIER_CLASS_WHITELIST) overhovedet indeholder de kvalificerende race-klasser (#2276-kaskaden: tier 3/4 kører ALDRIG Monuments eller klassikere).Fix: Ny delt helper
boardConstants.tierSupportsRaceScope(tier, raceScope)— begge steder gater nu mod den, og dropper/erstatter målet når det er umuligt.Test:
boardClubDna.test.js+boardConsequences.test.js— dækker tier 1 (opnåeligt), tier 2 (opnåeligt, OtherWorldTourB/C overlapper), tier 3/4 (umuligt, droppes), samt at ikke-race-klasse-bundne tradition-mål (fxmin_national_riders) aldrig gates.Data-reparation:
database/proposals/2026-07-31-3095-italiensk-klassiker-monument-goal-repair.sql— idempotent, fjerner det umulige mål fracurrent_goalsfor de 5 bekræftede tier-3-hold (Ardennaise Pro Cycling Team, Bad At Names, Hopplà Team, Kemphanen Cycling Team, Nickstar Rockets). Verificeret read-only mod prod (exact board_id'er + bug-signatur i SQL-kommentarerne). IKKE appliet — ligger idatabase/proposals/(uden for auto-migrate.yml's glob) og afventer ejer-godkendelse, samme mønster som #2881.#3141 — 5-års-planen tæller ikke stjerne-ryttere som bestyrelsen selv anerkender
Rod-årsag:
signature_rider-målets evaluator (boardGoals.js, to steder:evaluateGoal+evaluateGoalProgress) brugte råpopularity >= 75, mens board-kortets "bestyrelsen anerkender N stjerne-ryttere" (boardIdentity.jsstar_profile) bruger et blandet score (popularity*0.70 + uciScore*0.30 >= 68,STAR_RIDER_SCORE_THRESHOLD). En rytter med moderat omdømme men høje UCI-point kunne derfor tælle på board-kortet uden at tælle mod planen (og omvendt).Fix:
calculateRiderStarScore+STAR_RIDER_SCORE_THRESHOLDeksporteret fraboardIdentity.js, begge evaluerings-steder iboardGoals.jsbruger nu samme SSOT.Test:
boardGoalTypes.test.js— ny rider-fixture demonstrerer begge retninger af den gamle uoverensstemmelse (score-kvalificeret rytter der IKKE talte under den gamle regel, og popularity-kvalificeret rytter der IKKE er en board-stjerne under den nye).Copy:
goalHelp.signature_rider(EN+DA,frontend/public/locales/{en,da}/board.json) opdateret så teksten matcher det nye kriterium.#3144 — bestyrelsen reagerer på løb fra en division holdet ikke er i
Rod-årsag:
processBoardWeekendFinalization(kaldt pr. finaliseret løb fraraceRunner.js+pcmResultsImport.js) skrev et race-mærketboard_satisfaction_events-row for alle rigtige hold, uanset om løbet var i holdets pulje/division.BoardSatisfactionTimeline.jsxviser race_name + satisfaction-delta pr. event — så en Division 2-manager så bestyrelsen "reagere" (grøn +X%) på et Division 3-løb holdet aldrig kørte.Fix:
race.league_division_idsendes nu med fra begge kaldesteder (raceRunner.jsx2,pcmResultsImport.js); nyraceMatchesTeamPool(race, standing)-helper filtrerer event-skrivningen til kun hold i løbets egen pulje. Selve satisfaction-tal-mekanikken (target-tracking mod holdets egen standing) er urørt — kun det viste, race-mærkede event er filtreret.Test:
boardWeekendFinalization.test.js— 3 nye tests (pulje-mismatch → intet event, pulje-match → event skrives, løb uden pulje-id → bagudkompatibel/ufiltreret).Test plan
npm test --prefix backend— 4796/4796 grønnenpm run lint --prefix frontend— 0 fejl (4 pre-eksisterende warnings i urørte filer)Brugerverifikation (KRÆVET)
Hvad jeg verificerede konkret: Læste live prod-data (read-only, Supabase MCP) for at bekræfte at de 5 hold i #3095 rent faktisk har bug-signaturen i
current_goalsog at ingen andre hold er ramt af samme mønster — se SQL-filens kvantificerings-kommentar for de eksakteboard_id'er.Risk / auto-merge
auto-merge— IKKE sat: berører bestyrelses-evaluering (satisfaction-tal-flow) + en usignet data-reparation, kræver ejer-reviewFiler rørt
backend/lib/boardClubDna.js,boardConsequences.js,boardConstants.js,boardGoals.js,boardIdentity.js,boardWeekendFinalization.js,pcmResultsImport.js,raceRunner.js+ tilhørende.test.js-filerdatabase/proposals/2026-07-31-3095-italiensk-klassiker-monument-goal-repair.sql(ny, IKKE appliet)frontend/public/locales/{en,da}/board.json(kun tekst)Skærmbillede / video
Ingen — ingen UI-ændring.
Close-out (efter merge til main)
.claude/learnings/— postmortem tilføjes ved merge (samme rodårsags-familie som [feature] Board: monument-arketype skal honorere klassikere (arketype-race-kategori alignment) #1238/[bug/high] Prestige-kaskade brudt: Div 4 kører Div 1's monumenter + WT-løb — fuld kalender-ombygning + reversering af 8 afviklede løb #2276: tier/pulje-filter manglede ét sted, fandtes korrekt et andet sted)claude:done-label sættes ved merge