Skip to content

scheduler/printers.c: Don't remove processing temp queue - #364

Merged
zdohnal merged 1 commit into
OpenPrinting:masterfrom
zdohnal:temp_queues_cleanup
Apr 7, 2022
Merged

zdohnal merged 1 commit into
OpenPrinting:masterfrom
zdohnal:temp_queues_cleanup

Conversation

@zdohnal

@zdohnal zdohnal commented Apr 6, 2022

Copy link
Copy Markdown
Member

cupsdDeleteTemporaryPrinters() deletes temporary queues which their last
status was updated 1 minute ago or older. It doesn't take into account
the fact the printer can be processing a big print job and cupsd deletes
the temp queue either way.

The fix in the PR now set cupsd to ignore queues which are in processing
state. If the delay in job processing is caused by an error in printer,
the correct error should kick in IPP backend.

cupsdDeleteTemporaryPrinters() deletes temporary queues which their last
status was updated 1 minute ago or older. It doesn't take into account
the fact the printer can be processing a big print job and cupsd deletes
the temp queue either way.

The fix in the PR now set cupsd to ignore queues which are in processing
state. If the delay in job processing is caused by an error in printer,
the correct error should kick in IPP backend.
@zdohnal zdohnal added bug Something isn't working priority-medium labels Apr 6, 2022
@zdohnal zdohnal added this to the 2.4.2 milestone Apr 6, 2022
@zdohnal

zdohnal commented Apr 6, 2022 •

Copy link
Copy Markdown
Member Author

At this specific case the delay in printing was caused by 'printer being busy' (based on https://www.pwg.org/archives/ipp/2015/018399.html) or spool area was really full and the printer stuck. Here is the log.

IMHO IPP backend should exit with error after some timeout rather than cupsd cleaning up the queue.

@michaelrsweet is there a way how to clear the spooler on the printer by some IPP command? I get similar issue (printer reporting spool-area-full-report) on my printer sometimes, and only remedy I've found is to restart the whole device...

@michaelrsweet michaelrsweet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zdohnal

zdohnal commented Apr 7, 2022

Copy link
Copy Markdown
Member Author

Thx for the review! Merging.

@zdohnal
zdohnal merged commit 480b43f into OpenPrinting:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority-medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants