Repository navigation
Trigger feedback banner after editing experience and release usage - #6126
Merged
Merged
Conversation
Require three lifetime actions across two categories and 20 minutes of active editing per release. Show the banner during a quiet moment and acknowledge clicks or dismissal for that release. Keep editing hooks small, preserve Qt signal behavior, and remove the input filter on shutdown. Cover eligibility, editing commands, 154 live menu actions, undo/redo, and shutdown with regression tests. Validation: all 612 tests passed; git diff --check passed.
Simplify test helpers and type checks, retain intentional invalid-call coverage, and document narrow suppressions for trusted test subprocesses. Validation: all 612 tests passed; git diff --check passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require three lifetime actions across two categories and 20 minutes of active editing per release. Show the banner during a quiet moment and acknowledge clicks or dismissal for that release.
Keep editing hooks small, preserve Qt signal behavior, and remove the input filter on shutdown. Cover eligibility, editing commands, 154 live menu actions, undo/redo, and shutdown with regression tests.