Skip to content

Trigger feedback banner after editing experience and release usage - #6126

Merged
jonoomph merged 2 commits into
developfrom
feedback-banner-trigger
Sep 13, 2026
Merged

jonoomph merged 2 commits into
developfrom
feedback-banner-trigger

Conversation

@jonoomph

Copy link
Copy Markdown
Member

Require three lifetime actions across two categories and 20 minutes of active editing per release. Show the banner during a quiet moment and acknowledge clicks or dismissal for that release.

Keep editing hooks small, preserve Qt signal behavior, and remove the input filter on shutdown. Cover eligibility, editing commands, 154 live menu actions, undo/redo, and shutdown with regression tests.

Require three lifetime actions across two categories and 20 minutes of active editing per release. Show the banner during a quiet moment and acknowledge clicks or dismissal for that release.

Keep editing hooks small, preserve Qt signal behavior, and remove the input filter on shutdown. Cover eligibility, editing commands, 154 live menu actions, undo/redo, and shutdown with regression tests.

Validation: all 612 tests passed; git diff --check passed.
@jonoomph

Copy link
Copy Markdown
Member Author

Simplify test helpers and type checks, retain intentional invalid-call coverage, and document narrow suppressions for trusted test subprocesses.

Validation: all 612 tests passed; git diff --check passed.
@jonoomph
jonoomph merged commit ae860e1 into develop Sep 13, 2026
8 checks passed
@jonoomph
jonoomph deleted the feedback-banner-trigger branch September 13, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant