Skip to content

Celebrate successful exports, export summary, and ask for feedback afterward - #6214

Merged
jonoomph merged 12 commits into
developfrom
feedback-export-confetti
Oct 20, 2026
Merged

jonoomph merged 12 commits into
developfrom
feedback-export-confetti

Conversation

@jonoomph

Copy link
Copy Markdown
Member

Finishing an export is the most exciting moment in OpenShot, so this PR makes it feel
like one. It also moves our feedback invitation to right after that moment, instead of
popping it up after some amount of general use.

  • Feedback after a successful export: The feedback banner now appears only after
    the first successful export of each release, once the export dialog is closed. The old
    usage timers, action counting, and scattered tracking hooks are removed.
  • Confetti: A confetti burst plays when an export succeeds. A new Celebrate
    Exports
    preference (First Export, Every Export, Never) controls it, and the default
    is the first export.
  • Export summary tab: When an export finishes, a third Complete tab opens with
    the file location, a copy button, and cards for format, resolution, quality, file
    size, duration, and export time. Watch Video opens the file in the default player,
    and Open Containing Folder shows the file in the system file manager on Linux
    (including Snap, Flatpak, and AppImage), Windows, and macOS.
  • Export failures: A failed export opens a matching Export Failed tab with a
    red banner and the error details. It also offers Copy Error Details and a Try
    Again
    button that reopens the export dialog with the same settings.
  • Settings stay visible: The Simple and Advanced tabs stay browsable but read-only
    after the export finishes, so you can see exactly which settings were used.
  • Theme-friendly: All colors come from the active theme, so the new tabs work in
    Cosmic Dusk, Humanity: Dark, and Retro.
  • Dialog size and spacing: The export dialog now opens at 470×523 and never
    changes size when the results appear. Cosmic Dusk's extra spacing around the file
    name, folder, and tabs is tightened.
  • Test fixes: A few existing thumbnail and preview tests now pass when run on
    their own.

Replace the editing-time and action-count trigger with a single gate: the
first successful export of each release. The banner is queued on the main
window behind the export dialog, so closing the dialog reveals it.

Celebrate a successful export with confetti cannons over the finished
export dialog (or the main window when that dialog is disabled). A new
"Celebrate Exports" preference chooses First Export (default), Every
Export, or Never.

Remove the feedback command decorator, clip snapshots, idle and playback
tracking, and the now-unused feedback settings and tests.
Stub thumbnail cache id lookups that depended on a project left behind by
earlier tests, and create the preview window test's QApplication with
arguments.
After a successful export, a summary replaces the settings tabs: a success
banner, the file location with a copy button, cards for format,
resolution, quality, size and duration, and actions to reveal or play the
file. Colors derive from the active theme's text color with translucent
overlays, the primary button uses each theme's dialog accent, and cards
reflow from three columns when larger fonts need room.

Opening and revealing work on every platform: on Linux through the
desktop portal's OpenFile and OpenDirectory (host, AppImage, Snap and
Flatpak), then xdg-open without bundled loader paths; Explorer and Finder
select the file on Windows and macOS; Qt's openUrl is the final fallback.
Instead of replacing the settings, add and activate a "Complete" tab
after a successful export, or an "Export Failed" tab after an error. The
Simple and Advanced tabs stay browsable but read-only, so the settings
used remain visible.

The result tab never changes the dialog size: its details scroll above a
pinned action row, and it reports no minimum size. Themes paint it like
the other export tabs.

Failures use the same style with a red banner, the error details, a Copy
Error Details link, and Try Again, which reopens the export dialog with
the same settings. The progress bar turns red instead of green, and the
finished dialog no longer shows a separate error message box.

Keep result widgets out of saved export settings.
…port time

- Draw the status badge mark in pixmap units, so the check is centered and sized.
- Quality cards show 1-3 filled signal bars instead of the same star.
- File location sits in a quiet card with a flat copy button.
- Add an Export Time card (and an Audio card for audio exports) so rows fill
  evenly; cards prefer full rows (4 cards as 2x2).
- Style from Active palette colors; the tab is built while the dialog is still
  disabled, which made light themes' muted text far too faint.
- Open Containing Folder falls back to FileManager1.ShowItems to select the
  file when the OpenURI portal is unavailable.
The dialog grows to its layout minimum where a theme needs more height.
In narrow tabs the folder link reads "Show in Folder" (full text in its
tooltip) instead of clipping beside the primary button.
The Browse button's padding made the Folder Path row taller than File Name,
and the 16px tab margin left a large gap above the tabs.
The result tab and confetti get the moment first; the banner appears when
the user clicks Done. Without the finished dialog it still appears right
after the export.
@jonoomph

Copy link
Copy Markdown
Member Author

@jonoomph
jonoomph merged commit f249b3b into develop Oct 20, 2026
26 checks passed
@jonoomph
jonoomph deleted the feedback-export-confetti branch October 20, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant