Repository navigation
Correctly handle overlapping raw HTML matches (2) - #770
Conversation
waylan
left a comment
There was a problem hiding this comment.
Thanks for the update.
However, I note that you added the test to the Legacy Tests rather than the new Markdown TestCase. We would prefer all new tests to use the new framework. Ideally, a new file would be created at tests/test_syntax/extensions/fenced_code.py, which included a markdown.test_tools.TestCase subclass with a method to test the relevant behavior.
As explained in #622 the goal is to eventually have all tests implemented in the new framework. Adding tests to the old only doubles the work so we'd prefer all new tests to be int he new framework.
Finally, please don't create a new PR. You may simply push any changes to your branch and GitHub will add them to this PR. We will squash the commits when we merge to master.
Also move to release note to top (newer comes first).
(Recreated because #769 didn't respect the Contributing Guide)
Instead of rewriting the raw HTML substitution logic I chose to run it recursively until the output is equal to the previous input.
With kinds regards,
Philip Trauner