Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements
GET /api/jobs/:idendpoint to resolve specific jobs by id from the in-memory dataset, returns standard 404 fallback when non-existent, encapsulates the mutablejobsstore defensively, and fixes rootnpm testdiscovery.Details of Changes
Service Lookup & Encapsulation (
apps/api/src/services/jobService.js):getJobById(id)lookup helper returning the matched job or null.listJobs()with defensive array copy[...jobs]._resetJobs()helper for deterministic test isolation.Controller (
apps/api/src/controllers/jobController.js):getJobcontroller returning HTTP 200 with job payload or HTTP 404 with standard error body.try/catchwith Expressnext(err)forwarding.Routing (
apps/api/src/routes/jobRoutes.js):GET /:idroute handler.Test Discovery Fix (
apps/api/package.json):"test": "node --test"to satisfy issue Automate Bug Detection and ReviewsΒ #11398 and ensure clean root test suite execution.Automated Unit & Regression Tests (
apps/api/src/tests/job_detail.test.js):POST /api/jobsand subsequent retrieval viaGET /api/jobs/:id.Fixes #13478
/claim #13478
/claim #11202
/claim #743
/claim #11398