Skip to content

[ruby] Remove unnecessary and bug-creating code in platform.rb. - #10973

Merged
titusfortner merged 1 commit into
SeleniumHQ:trunkfrom
ch-saeki:fix_cygwin_check
Aug 25, 2022
Merged

titusfortner merged 1 commit into
SeleniumHQ:trunkfrom
ch-saeki:fix_cygwin_check

Conversation

@ch-saeki

@ch-saeki ch-saeki commented Aug 25, 2022 •

Copy link
Copy Markdown
Contributor

Description

When calling selenium's cygwin? method from ruby on cygwin, regexp match results was returning different judgment result from the actual one, so it was removed.

Motivation and Context

I ran it from cygwin, but it didn't return the correct results, so I looked into it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant

CLAassistant commented Aug 25, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ch-saeki ch-saeki changed the title [rb]: remove unnecessary and bug-creating code in platform.rb. [ruby]remove unnecessary and bug-creating code in platform.rb. Aug 25, 2022
@ch-saeki ch-saeki changed the title [ruby]remove unnecessary and bug-creating code in platform.rb. [ruby] Remove unnecessary and bug-creating code in platform.rb. Aug 25, 2022
@titusfortner

Copy link
Copy Markdown
Member

Ah, yes, looks like successive rubocop updates broke this. Thanks.

@titusfortner
titusfortner merged commit 1aba14e into SeleniumHQ:trunk Aug 25, 2022
@ch-saeki
ch-saeki deleted the fix_cygwin_check branch December 10, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants