Skip to content

Prevent double URL encoding - #256

Merged
grebnetiew merged 3 commits into
mainfrom
255-double-url-encoding
Feb 23, 2026
Merged

grebnetiew merged 3 commits into
mainfrom
255-double-url-encoding

Conversation

@Jelle-Nauta

@Jelle-Nauta Jelle-Nauta commented Feb 19, 2026 •

Copy link
Copy Markdown
Contributor

See #255, I renamed ParameterContents::to_url_encoding to ParameterContents::to_url_string and made it not URL-encode.

This function is used in two places in openapi/build_request.rs, on lines 35 and 45, to put ParameterContents in a URL query parameter and path parameter respectively. Both are passed only into reqwest::URL::parse (or parse_with_params), which handles encoding.

@Jelle-Nauta Jelle-Nauta self-assigned this Feb 19, 2026

@grebnetiew grebnetiew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@grebnetiew
grebnetiew merged commit 9acad79 into main Feb 23, 2026
13 checks passed
@grebnetiew
grebnetiew deleted the 255-double-url-encoding branch February 23, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants