Skip to content

Workaround popup player UI elements being pushed out / Set a maxWidth for audioTrackTextView - #12729

Merged
Stypox merged 1 commit into
TeamNewPipe:devfrom
litetex:workaround-popup-player-ui-elements-being-pushed-out
Oct 21, 2025
Merged

Stypox merged 1 commit into
TeamNewPipe:devfrom
litetex:workaround-popup-player-ui-elements-being-pushed-out

Conversation

@litetex

@litetex litetex commented Oct 20, 2025

Copy link
Copy Markdown
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

See #12714 for details

Before/After Screenshots/Screen Record

⚠ Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@litetex litetex added the player Issues related to any player (main, popup and background) label Oct 20, 2025
@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label Oct 20, 2025
@litetex litetex changed the title Workaround popup player UI elements being pushed out Workaround popup player UI elements being pushed out / Set a maxWidth for audioTrackTextView Oct 20, 2025

@Stypox Stypox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and this workaround is much better than overflowing buttons. Thanks!

There's still enough characters to understand the current langage:

Image

@Stypox
Stypox force-pushed the workaround-popup-player-ui-elements-being-pushed-out branch from e5171be to c81148a Compare October 21, 2025 16:14
@github-actions github-actions Bot added size/small PRs with less than 50 changed lines and removed size/medium PRs with less than 250 changed lines labels Oct 21, 2025
@Stypox
Stypox marked this pull request as ready for review October 21, 2025 16:15
@Stypox
Stypox merged commit 2a9c6f0 into TeamNewPipe:dev Oct 21, 2025
5 checks passed
@litetex
litetex deleted the workaround-popup-player-ui-elements-being-pushed-out branch October 21, 2025 17:52
@TobiGr TobiGr mentioned this pull request Dec 21, 2025
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

player Issues related to any player (main, popup and background) size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants