Skip to content

ci: fix shell injection in backport workflow - #13052

Merged
TobiGr merged 1 commit into
TeamNewPipe:devfrom
RinZ27:fix/ci-shell-injection
Jan 13, 2026
Merged

TobiGr merged 1 commit into
TeamNewPipe:devfrom
RinZ27:fix/ci-shell-injection

Conversation

@RinZ27

@RinZ27 RinZ27 commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

Found a potential shell injection point in backport-pr.yml. The workflow was directly interpolating github.event.comment.body into a run script, which is a bit risky if a comment contains backticks or other shell-sensitive characters.

I've refactored the "Get backport metadata" step to pass the comment body through an environment variable. This ensures the shell treats the input as a literal string and follows the official GitHub Actions security recommendations.

@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Jan 13, 2026

@TobiGr TobiGr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The security recommendations can be found here.

@TobiGr
TobiGr enabled auto-merge January 13, 2026 14:33
@TobiGr
TobiGr merged commit 2f063a7 into TeamNewPipe:dev Jan 13, 2026
6 checks passed
@RinZ27
RinZ27 deleted the fix/ci-shell-injection branch January 13, 2026 15:23
@AudricV AudricV added the template missing The bug/feature template is missing. No further action is taken until the template is applied. label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small PRs with less than 50 changed lines template missing The bug/feature template is missing. No further action is taken until the template is applied.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants