Repository navigation
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Stypox
approved these changes
Mar 1, 2026
Stypox
left a comment
Stypox
left a comment
Member
There was a problem hiding this comment.
Code LGTM, thank you!
If you have them at hand, could you provide youtube response snippets with the two JSON formats?
Also I guess after this gets deployed 100%, we'll have to update test mocks.
ShareASmile
added
bug
Contributor
Author
|
I've uploaded YouTube response snippets for the two JSON formats, one for the original thumbnailOverlayBadgeViewModel_response.json |
FineFindus
added a commit
to FineFindus/LibreTube
that referenced
this pull request
Mar 7, 2026
Includes TeamNewPipe/NewPipeExtractor#1464, which fixes the extraction of the duration of related videos. Closes: libre-tube#8217
FineFindus
added a commit
to libre-tube/LibreTube
that referenced
this pull request
Mar 7, 2026
Includes TeamNewPipe/NewPipeExtractor#1464, which fixes the extraction of the duration of related videos. Closes: #8217
litetex
self-requested a review
April 7, 2026 13:59
litetex
force-pushed
the
fix_fetching_yt_stream_info_item_lockup_duration
branch
from
April 7, 2026 14:06
d3d3c47 to
f7185dc
Compare
Member
|
So to get this finally fixed:
Should be good to merge now. |
litetex
force-pushed
the
fix_fetching_yt_stream_info_item_lockup_duration
branch
from
April 7, 2026 14:21
f7185dc to
c0cb0c6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
litetex
approved these changes
Apr 7, 2026
litetex
left a comment
litetex
left a comment
Member
There was a problem hiding this comment.
CI tests are successful. Ready to merge
litetex
added a commit
to litetex/NewPipe
that referenced
this pull request
Apr 8, 2026
To get the changes from TeamNewPipe/NewPipeExtractor#1464
4 of 7 tasks
AudricV
changed the title
simonchrz
added a commit
to simonchrz/NewPipeExtractor
that referenced
this pull request
May 21, 2026
Resolutions: - extractor/build.gradle.kts: keep HEAD signing config (FireMasterK CI cache fix) - YoutubeStreamExtractor.java getItags(): take upstream streamAsJsonObjects() refactor (PR TeamNewPipe#1485) — functionally equivalent to our verbose stream chain. Brings in: ExtractorLogger framework (PR TeamNewPipe#1403), YouTube item duration fix for lockup data (PR TeamNewPipe#1464, TeamNewPipe#1478), several Dependabot updates (gson, protobuf, gradle-wrapper, junit-bom).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently an A/B test where the names of the objects storing item durations can change, which causes
YoutubeStreamInfoItemLockupExtractor.getDuration()to occasionally fail to fetch item durations. ThethumbnailOverlayBadgeViewModelobject can appear asthumbnailBottomOverlayViewModel, and when that happens, thethumbnailBadgesarray is renamed tobadges.This pull request fixes TeamNewPipe/NewPipe#13281 by changing the method to support fetching item durations during the A/B test.