Repository navigation
Conversation
Member
|
個人的にはenumでもいいかな~って思います。 |
Hiroshiba
approved these changes
May 23, 2024
Member
|
@sevenc-nanashi 個人的には、そのメッセージが表示されたらVVMの破損を疑う気がします。 |
Member
Author
|
バージョンはなんとなく文字列にしたのですが、Cargo.lock見たら整数値だったし整数値の方がいいのかも? |
Member
確かにです!! 追記:そこさえ変えればマージしていただいても大丈夫そう! |
Member
Author
|
整数にしました。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
#581 (comment)の1.です。
manifest_version(SemVer)をvvm_format_version(整数値を文字列化したもの)にします。実装は#581 (comment)で書いたやつの冗長な方を持って来ました。
(エラーメッセージにこだわらないのなら
enumのやつでもいいかもしれません)関連 Issue
ref #581
その他