Skip to content

#830 の設計をUserDictにも - #834

Merged
qryxip merged 1 commit into
VOICEVOX:mainfrom
qryxip:chore-apply-pr-830-to-user-dict
Sep 24, 2024
Merged

qryxip merged 1 commit into
VOICEVOX:mainfrom
qryxip:chore-apply-pr-830-to-user-dict

Conversation

@qryxip

@qryxip qryxip commented Sep 24, 2024 •

Copy link
Copy Markdown
Member

内容

#830 のInner<A: Async>で共通化する設計をUserDictでもやり、それと共にasync-fsを導入することでasync APIとしての質を向上させます。

関連 Issue

その他

@qryxip
qryxip requested a review from Hiroshiba September 24, 2024 01:43

@Hiroshiba Hiroshiba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@qryxip
qryxip merged commit 9fdb347 into VOICEVOX:main Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants