Repository navigation
Add proper deprecation logic for features & deprecate Ammonite for removal - #4218
Merged
Merged
Conversation
Gedochao
force-pushed
the
update/ammonite-3.0.9
branch
3 times, most recently
from
April 9, 2026 12:50
5643695 to
ce924e5
Compare
Gedochao
force-pushed
the
update/ammonite-3.0.9
branch
from
April 9, 2026 12:50
ce924e5 to
afd89e8
Compare
Gedochao
force-pushed
the
update/ammonite-3.0.9
branch
from
April 9, 2026 12:54
afd89e8 to
5f46837
Compare
Gedochao
marked this pull request as ready for review
April 9, 2026 13:20
tgodzik
approved these changes
Apr 9, 2026
Gedochao
enabled auto-merge
April 10, 2026 04:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3258
--ammonite,--ammonite-version, and--ammonite-arg)Examples
scala-cli config suppress-warning.deprecated-features trueChecklist
scala-cli fmt .)scalafix(./mill -i __.fix)./mill -i 'generate-reference-doc[]'.run)How much have your relied on LLM-based tools in this contribution?
a lot; Cursor + Claude
How was the solution tested?
Added dummy features of each category and automated tests for how the CLI warns on each of them.
1.
--deprecated-test-option(full option deprecation)scala-cli run Hello.scala --deprecated-test-option # [warn] --deprecated-test-option is deprecated: For testing purposes only.2.
--deprecated-test-alias(alias deprecation)scala-cli run Hello.scala --deprecated-test-alias # [warn] --deprecated-test-alias is deprecated3.
//> using deprecatedTestDirective(directive deprecated with replacement)//> using deprecatedTestDirective4.
//> using deprecatedForRemovalTestDirective(directive deprecated for removal)//> using deprecatedForRemovalTestDirective5.
test.deprecated-key(config key deprecation)Tests pass locally.
Additional notes