Repository navigation
fix: fix tests not working on Windows - #4502
Merged
Merged
Conversation
fix tests not working on Windowsfix tests not working on Windows
Collaborator
Author
|
Also, I guess when we introduce the feature mentioned in #3330 this fix wouldn't be needed. |
4 tasks done
Contributor
I mean, a user could always explicitly try to run no rules at all... |
Gedochao
approved these changes
Sep 28, 2026
Collaborator
Author
True |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3428
So the tests ran scalafix, and since it couldn't find any rules it exited with
sys.exit(256). On macOS and Linux exit code has 8 bits and 256 is "translated" into 0 (hence the lack of error). On Windows the error code has 32 bits, so it doesn't happen and the tests result in an error.Checklist
scala-cli fmt .)scalafix(./mill -i __.fix)./mill -i 'generate-reference-doc[]'.run)How much have your relied on LLM-based tools in this contribution?
Moderately
How was the solution tested?
CI works