Repository navigation
perf: Try to load previous seqNr if missing, in validation - #1197
Merged
Merged
Conversation
patriknw
commented
Sep 12, 2024
Contributor
- makes it more safe to evict from memory, but keep more in database
- a step towards lazy loading of offsets, but full lazy loading would require many more changes due to the concurrency model used in the R2dbcOffsetStore
- otherwise it will use timestampOf, which are be more costly for gRPC projections
- it still falls back to timestampOf as last resort
patriknw
commented
Sep 12, 2024
| SELECT seq_nr, timestamp_offset | ||
| FROM $timestampOffsetTable WHERE slice = ? AND projection_name = ? AND persistence_id = ? | ||
| ORDER BY seq_nr DESC | ||
| LIMIT 1""" |
Contributor
Author
There was a problem hiding this comment.
I'm a little worried about the index for this since timestamp_offset is before persistence_id in:
PRIMARY KEY(slice, projection_name, timestamp_offset, persistence_id, seq_nr)
but might be fine?
Limit (cost=4.31..4.32 rows=1 width=16) (actual time=0.137..0.138 rows=1 loops=1)
-> Sort (cost=4.31..4.32 rows=1 width=16) (actual time=0.135..0.136 rows=1 loops=1)
Sort Key: seq_nr DESC
Sort Method: quicksort Memory: 25kB
-> Index Only Scan using akka_projection_timestamp_offset_store_pkey on akka_projection_timestamp_offset_store (cost=0.28..4.30 rows=1 width=16) (actual time=0.085..0.087 rows=2 loops=1)
Index Cond: ((slice = 449) AND (projection_name = 'b267e71d-7ed9-4f02-8726-b96b0783ae7a'::text) AND (persistence_id = 'p1'::text))
Heap Fetches: 0
The reason timestamp_offset is before is for the deletes.
Member
There was a problem hiding this comment.
Could also have an optional extra index for this.
Contributor
Author
|
One thing that this could enable as a next step would be to decouple the db deletes from how much it holds in memory. I'd like to keep things in db for much longer than the in-memory window. |
johanandren
approved these changes
Sep 13, 2024
patriknw
force-pushed
the
wip-validate-load-patriknw
branch
from
October 9, 2024 14:52
6b5d439 to
123524b
Compare
* makes it more safe to evict from memory, but keep more in database * a step towards lazy loading of offsets, but full lazy loading would require many more changes due to the concurrency model used in the R2dbcOffsetStore * otherwise it will use timestampOf, which are be more costly for gRPC projections * it still falls back to timestampOf as last resort
patriknw
force-pushed
the
wip-validate-load-patriknw
branch
from
October 18, 2024 09:41
123524b to
d825c85
Compare
patriknw
added a commit
that referenced
this pull request
Oct 18, 2024
* perf: Try to load previous seqNr if missing, in validation * makes it more safe to evict from memory, but keep more in database * a step towards lazy loading of offsets, but full lazy loading would require many more changes due to the concurrency model used in the R2dbcOffsetStore * otherwise it will use timestampOf, which are be more costly for gRPC projections * it still falls back to timestampOf as last resort * different sql for SqlServer (cherry picked from commit e956248)
patriknw
added a commit
that referenced
this pull request
Oct 18, 2024
…1229) * perf: Try to load previous seqNr if missing, in validation * makes it more safe to evict from memory, but keep more in database * a step towards lazy loading of offsets, but full lazy loading would require many more changes due to the concurrency model used in the R2dbcOffsetStore * otherwise it will use timestampOf, which are be more costly for gRPC projections * it still falls back to timestampOf as last resort * different sql for SqlServer (cherry picked from commit e956248)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.