Skip to content

chore: Use tagged sdk version in update job - #1056

Merged
patriknw merged 2 commits into
mainfrom
wip-sdk-version-patriknw
Oct 16, 2025
Merged

patriknw merged 2 commits into
mainfrom
wip-sdk-version-patriknw

Conversation

@patriknw

Copy link
Copy Markdown
Contributor

Something went wrong in #1055
Probably because something else was merged and determine-sdk-version.sh was used

https://github.com/akka/akka-sdk/actions/runs/18532994985/job/52820541197

It was also overly complicated, in my opinion.


- name: Create PR to update all sdk versions (samples, sbt and maven)
env:
SDK_VERSION: ${{ steps.determine_sdk_version.outputs.sdk_version || steps.determine_sdk_version_manual_triggered.outputs.sdk_version }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go as well then?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@patriknw
patriknw merged commit 279f486 into main Oct 16, 2025
1 check passed
@patriknw
patriknw deleted the wip-sdk-version-patriknw branch October 16, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants