Repository navigation
fix: relax validation for Agent handlers - #1139
Merged
Merged
Conversation
patriknw
reviewed
Nov 13, 2025
| "No method returning akka.javasdk.agent.Agent.Effect, akka.javasdk.agent.Agent.StreamEffect found") | ||
| } | ||
|
|
||
| "reject Agent without command handler" in { |
Contributor
There was a problem hiding this comment.
why is this removed? It must have one command handler?
Contributor
Author
There was a problem hiding this comment.
I removed because there is already another test checking it.
The one just above this is: "reject Agent without Effect method"
| "There must be one public method returning Agent.Effect") | ||
| } | ||
|
|
||
| "reject Agent with multiple command handlers" in { |
Contributor
There was a problem hiding this comment.
isn't the problem that the validation is also including private methods? There should be one, and only one public (or package private) command handler. The LedgerAgent has private methods.
Contributor
Author
There was a problem hiding this comment.
Oh, you are right. I will fix this them.
octonato
force-pushed
the
octonato/allow-more-than-one-cmd-handler
branch
from
November 13, 2025 12:36
a336650 to
1456722
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.