Repository navigation
chore: serveral compile validations improvements - #1176
Merged
Merged
Conversation
octonato
commented
Nov 20, 2025
| @Component(id = "consumer-with-function-tool") | ||
| @Consume.FromTopic("my-topic") | ||
| public class ConsumerWithFunctionToolOnPrivateMethod extends Consumer { | ||
| public class ConsumerWithFunctionTool extends Consumer { |
Contributor
Author
There was a problem hiding this comment.
We had a rule blocking the usage of @FunctionTool in Consumer's private methods, but instead we should block it on all kind of methods. A consumer should only be called from the projection running it, never from an agent.
Contributor
Author
|
There was another comment about checking It seems that this is need in some cases related with usage of inner classes, but I need to look into that in detail. I will send a follow up PR with more clean-ups. |
octonato
commented
Nov 21, 2025
Comment on lines
-113
to
-114
| if (returnTypeName.equals(effectTypeName) | ||
| || returnTypeName.startsWith(effectTypeName + "<")) { |
Contributor
Author
There was a problem hiding this comment.
It turns out that the reason why we "needed" to check on '<' was because the first check was using equals. It was late yesterday when I tried to clean this up and I didn't notice it.
octonato
force-pushed
the
octonato/minor-validation-cleanup
branch
from
November 21, 2025 17:08
e33f111 to
692680c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.