Skip to content

build: improving rsync for akka sample SDK version bump - #1224

Merged
aludwiko merged 1 commit into
mainfrom
fixing-pr-akk-samples
Jan 5, 2026
Merged

aludwiko merged 1 commit into
mainfrom
fixing-pr-akk-samples

Conversation

@aludwiko

Copy link
Copy Markdown
Contributor

No description provided.

ls -l pom.xml ../docs/build/bundle/${{ matrix.sample }}/pom.xml
if [ -f "../docs/build/bundle/${{ matrix.sample }}/pom.xml" ]; then cat ../docs/build/bundle/${{ matrix.sample }}/pom.xml; fi
rsync -av ../docs/build/bundle/${{ matrix.sample }}/ ./
rsync -avc ../docs/build/bundle/${{ matrix.sample }}/ ./

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently we might hit a known rsync issue:

When both of these are true:
 - pom.xml already exists in the destination
 - The source pom.xml has:
   - the same size
   - the same mtime (or older)

rsync will skip the file, even if the content is different.

-c = checksum comparison, it's a bit slower, but it doesn't matter in this case.

Let's see if that helps.

@johanandren johanandren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems worth a shot

@johanandren johanandren changed the title fix: improving rsync for akka sample SDK version bump build: improving rsync for akka sample SDK version bump Jan 5, 2026

@patriknw patriknw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try, but I since it often fixed itself on a build retry I don't fully see that this could be the reason

@aludwiko
aludwiko merged commit 653e61d into main Jan 5, 2026
113 of 114 checks passed
@aludwiko
aludwiko deleted the fixing-pr-akk-samples branch January 5, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants