Repository navigation
feat: Http endpoint web socket support - #1246
Merged
Merged
Conversation
Contributor
Author
|
Can not go in until we have infrastructure in place, and then docs covering that should also go here before ready for merge. |
patriknw
reviewed
Jan 15, 2026
johanandren
force-pushed
the
wip-websocket-endpoint-support
branch
from
January 15, 2026 13:22
babd69f to
4f39f7f
Compare
patriknw
reviewed
Jan 15, 2026
# Conflicts: # project/Dependencies.scala
johanandren
force-pushed
the
wip-websocket-endpoint-support
branch
from
January 23, 2026 12:53
fe182b5 to
be315d6
Compare
johanandren
marked this pull request as ready for review
January 26, 2026 10:37
patriknw
approved these changes
Jan 29, 2026
| */ | ||
| // Opened up for access from the public internet to make the service easy to try out. | ||
| // For actual services meant for production this must be carefully considered, | ||
| // and often set more limited |
Contributor
There was a problem hiding this comment.
does JavaDoc allow such // comments between the /** and the class?
Contributor
Author
There was a problem hiding this comment.
Not sure, but we do it all over the samples already.
|
|
||
| // Note: using websocket in a deployed service requires additional steps, see the documentation | ||
| // tag::ws-view-updates[] | ||
| @WebSocket("/by-city-ws/{cityName}") // <1> |
Contributor
There was a problem hiding this comment.
should we use a prefix, like we recommend?
/ws/by-city/{cityName}
Contributor
Author
There was a problem hiding this comment.
Hmm, maybe better yeah, needs to go in its own endpoint class then because this already has /customer as class wide prefix.
Contributor
Author
There was a problem hiding this comment.
Changed both sample snippets to have a /websockets prefix, aligned with the descriptor sample prefix now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References https://github.com/lightbend/akka-runtime/issues/4621
Depends on runtime changes in https://github.com/lightbend/akka-runtime/pull/4695 (in runtime release 1.5.31)